chrome/browser/devtools/devtools_targets_ui.cc - Issue 291403002: Remove some RenderProcessHost::IsGuest call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 291403002: Remove some RenderProcessHost::IsGuest call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Android build Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_targets_ui.cc

diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc

index 868d8da867c5b80d16d9429d9243820dc4473459..321d962fa72e46557f2e1ac6983dc84a61279a90 100644

--- a/chrome/browser/devtools/devtools_targets_ui.cc

+++ b/chrome/browser/devtools/devtools_targets_ui.cc

@@ -163,7 +163,9 @@ void RenderViewHostTargetsUIHandler::UpdateTargets() {

// Revisit this when multiple OOP frames are supported.

RenderFrameHost* rfh = rvh->GetMainFrame();

rfh_to_descriptor[rfh] = descriptor;

- if (rvh->GetProcess()->IsGuest() || rfh->IsCrossProcessSubframe()) {

+ content::WebContents* web_contents =

+ content::WebContents::FromRenderViewHost(rvh);

+ if (GuestViewBase::IsGuest(web_contents) || rfh->IsCrossProcessSubframe()) {

nested_frames.push_back(rfh);

} else {

list_value->Append(descriptor);