Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: services/resource_coordinator/coordination_unit/coordination_unit_impl.h

Issue 2914003002: [GRC] Coordination Unit Manager Modularization (Closed)
Patch Set: Add CoordinationUnitManager comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/coordination_unit/coordination_unit_impl.h
diff --git a/services/resource_coordinator/coordination_unit/coordination_unit_impl.h b/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
index ff854476100dc38a0221a65470556306afbc7219..6604ec2675924f73f30e8faa26221eb3e1cf968b 100644
--- a/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
+++ b/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
@@ -36,10 +36,18 @@ class CoordinationUnitImpl : public mojom::CoordinationUnit {
void SetCoordinationPolicyCallback(
mojom::CoordinationPolicyCallbackPtr callback) override;
+ const CoordinationUnitID& id() const { return id_; }
+ const std::set<CoordinationUnitImpl*>& children() const { return children_; }
+ const std::set<CoordinationUnitImpl*>& parents() const { return parents_; }
+
+ static const double kCPUUsageMinimumForTesting;
+ static const double kCPUUsageUnmeasuredForTesting;
virtual double GetCPUUsageForTesting();
protected:
- CoordinationUnitID id_;
+ const CoordinationUnitID id_;
+ std::set<CoordinationUnitImpl*> children_;
+ std::set<CoordinationUnitImpl*> parents_;
private:
bool AddChild(CoordinationUnitImpl* child);
@@ -63,9 +71,6 @@ class CoordinationUnitImpl : public mojom::CoordinationUnit {
std::unique_ptr<service_manager::ServiceContextRef> service_ref_;
mojo::BindingSet<mojom::CoordinationUnit> bindings_;
- std::set<CoordinationUnitImpl*> children_;
- std::set<CoordinationUnitImpl*> parents_;
-
mojom::CoordinationPolicyCallbackPtr policy_callback_;
mojom::CoordinationPolicyPtr current_policy_;

Powered by Google App Engine
This is Rietveld 408576698