Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2561)

Unified Diff: services/resource_coordinator/coordination_unit/coordination_unit_impl.cc

Issue 2914003002: [GRC] Coordination Unit Manager Modularization (Closed)
Patch Set: Add CoordinationUnitManager comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
diff --git a/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc b/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
index 7fd7870b5e59599f6b026a973add5101cbb895d5..034b9e42aebe4a11c7be689d2194e9590f3955d4 100644
--- a/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
+++ b/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
@@ -8,10 +8,7 @@
#include <unordered_map>
#include <utility>
-#include "base/logging.h"
-#include "base/process/process_handle.h"
#include "base/strings/string_number_conversions.h"
-#include "base/unguessable_token.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/resource_coordinator/public/cpp/coordination_unit_id.h"
@@ -28,16 +25,13 @@ CUIDMap& g_cu_map() {
} // namespace
+const double CoordinationUnitImpl::kCPUUsageMinimumForTesting = 0.0;
+const double CoordinationUnitImpl::kCPUUsageUnmeasuredForTesting = -1.0;
+
CoordinationUnitImpl::CoordinationUnitImpl(
const CoordinationUnitID& id,
- std::unique_ptr<service_manager::ServiceContextRef> service_ref) {
- if (!id.id) {
- id_ = CoordinationUnitID(id.type,
- base::UnguessableToken().Create().ToString());
- } else {
- id_ = id;
- }
-
+ std::unique_ptr<service_manager::ServiceContextRef> service_ref)
+ : id_(id.type, id.id) {
auto it = g_cu_map().insert(std::make_pair(id_, this));
DCHECK(it.second); // Inserted successfully
@@ -219,7 +213,7 @@ void CoordinationUnitImpl::UnregisterCoordinationPolicyCallback() {
}
double CoordinationUnitImpl::GetCPUUsageForTesting() {
- return -1.0;
+ return kCPUUsageUnmeasuredForTesting;
}
} // namespace resource_coordinator

Powered by Google App Engine
This is Rietveld 408576698