Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2913993003: Fix typos in resources OWNERS file. (Closed)

Created:
3 years, 6 months ago by skym
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jiahuiguo1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typos in resources OWNERS file. I introduced an error in this OWNERS file in https://chromium.googlesource.com/chromium/src/+/6c146620037bf6c1222d5a0255be9a6ef2ce5137 Owners presubmit checks for files in components/resources are failing with an error like: File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry ('%s does not refer to an existing file.' % directive[5:])) owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file. TBR=jochen NOPRESUBMIT=true BUG= Review-Url: https://codereview.chromium.org/2913993003 Cr-Commit-Position: refs/heads/master@{#476369} Committed: https://chromium.googlesource.com/chromium/src/+/04b5424ac2e113a8ddbd18584b0e86a3a03299ae

Patch Set 1 #

Patch Set 2 : Actually fix the supervised_user typo for real. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/resources/OWNERS View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
skym
PTAL
3 years, 6 months ago (2017-05-31 21:46:48 UTC) #7
skym
Note that the Presubmit failure is because of owners.py's override_files mechanism. If you modify it ...
3 years, 6 months ago (2017-05-31 22:18:12 UTC) #10
skym
+thestig , just a simple OWNERs fix, trying to get this in ASAP as this ...
3 years, 6 months ago (2017-06-01 17:01:48 UTC) #12
Lei Zhang
lgtm, but I don't think I'm an owner here? TBR?
3 years, 6 months ago (2017-06-01 18:39:42 UTC) #15
skym
On 2017/06/01 18:39:42, Lei Zhang wrote: > lgtm, but I don't think I'm an owner ...
3 years, 6 months ago (2017-06-01 18:42:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913993003/20001
3 years, 6 months ago (2017-06-01 18:43:14 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 18:44:14 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/04b5424ac2e113a8ddbd18584b0e...

Powered by Google App Engine
This is Rietveld 408576698