|
|
Chromium Code Reviews
DescriptionFix typos in resources OWNERS file.
I introduced an error in this OWNERS file in https://chromium.googlesource.com/chromium/src/+/6c146620037bf6c1222d5a0255be9a6ef2ce5137
Owners presubmit checks for files in components/resources are failing with an error like:
File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry
('%s does not refer to an existing file.' % directive[5:]))
owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file.
TBR=jochen
NOPRESUBMIT=true
BUG=
Review-Url: https://codereview.chromium.org/2913993003
Cr-Commit-Position: refs/heads/master@{#476369}
Committed: https://chromium.googlesource.com/chromium/src/+/04b5424ac2e113a8ddbd18584b0e86a3a03299ae
Patch Set 1 #Patch Set 2 : Actually fix the supervised_user typo for real. #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by skym@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Fix typos in resources OWNERS file.
BUG=
==========
to
==========
Fix typos in resources OWNERS file.
Owners presubmit checks for files in components/resources are failing with an
error like:
File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357,
in _add_entry
('%s does not refer to an existing file.' % directive[5:]))
owners.SyntaxErrorInOwnersFile:
/usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24
syntax error: components/sync/OWNERS does not refer to an existing file.
BUG=
==========
skym@chromium.org changed reviewers: + jochen@chromium.org
The CQ bit was checked by skym@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Note that the Presubmit failure is because of owners.py's override_files mechanism. If you modify it to read the current OWNERS file off disk, it succeeds.
skym@chromium.org changed reviewers: + thestig@chromium.org
+thestig , just a simple OWNERs fix, trying to get this in ASAP as this is blocking anyone modifying files in components/resources/ from using the CQ.
Description was changed from
==========
Fix typos in resources OWNERS file.
Owners presubmit checks for files in components/resources are failing with an
error like:
File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357,
in _add_entry
('%s does not refer to an existing file.' % directive[5:]))
owners.SyntaxErrorInOwnersFile:
/usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24
syntax error: components/sync/OWNERS does not refer to an existing file.
BUG=
==========
to
==========
Fix typos in resources OWNERS file.
I introduced an error in this OWNERS file in
https://codereview.chromium.org/2872023002/
Owners presubmit checks for files in components/resources are failing with an
error like:
File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357,
in _add_entry
('%s does not refer to an existing file.' % directive[5:]))
owners.SyntaxErrorInOwnersFile:
/usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24
syntax error: components/sync/OWNERS does not refer to an existing file.
BUG=
==========
Description was changed from ========== Fix typos in resources OWNERS file. I introduced an error in this OWNERS file in https://codereview.chromium.org/2872023002/ Owners presubmit checks for files in components/resources are failing with an error like: File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry ('%s does not refer to an existing file.' % directive[5:])) owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file. BUG= ========== to ========== Fix typos in resources OWNERS file. I introduced an error in this OWNERS file in https://chromium.googlesource.com/chromium/src/+/6c146620037bf6c1222d5a0255be... Owners presubmit checks for files in components/resources are failing with an error like: File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry ('%s does not refer to an existing file.' % directive[5:])) owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file. BUG= ==========
lgtm, but I don't think I'm an owner here? TBR?
Description was changed from ========== Fix typos in resources OWNERS file. I introduced an error in this OWNERS file in https://chromium.googlesource.com/chromium/src/+/6c146620037bf6c1222d5a0255be... Owners presubmit checks for files in components/resources are failing with an error like: File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry ('%s does not refer to an existing file.' % directive[5:])) owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file. BUG= ========== to ========== Fix typos in resources OWNERS file. I introduced an error in this OWNERS file in https://chromium.googlesource.com/chromium/src/+/6c146620037bf6c1222d5a0255be... Owners presubmit checks for files in components/resources are failing with an error like: File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry ('%s does not refer to an existing file.' % directive[5:])) owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file. TBR=jochen NOPRESUBMIT=true BUG= ==========
On 2017/06/01 18:39:42, Lei Zhang wrote: > lgtm, but I don't think I'm an owner here? TBR? Noted, setting TBR=jochen
The CQ bit was checked by skym@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496342548894750,
"parent_rev": "e15e8c228ed7d48f5979537d54967326e37ba421", "commit_rev":
"04b5424ac2e113a8ddbd18584b0e86a3a03299ae"}
Message was sent while issue was closed.
Description was changed from ========== Fix typos in resources OWNERS file. I introduced an error in this OWNERS file in https://chromium.googlesource.com/chromium/src/+/6c146620037bf6c1222d5a0255be... Owners presubmit checks for files in components/resources are failing with an error like: File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry ('%s does not refer to an existing file.' % directive[5:])) owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file. TBR=jochen NOPRESUBMIT=true BUG= ========== to ========== Fix typos in resources OWNERS file. I introduced an error in this OWNERS file in https://chromium.googlesource.com/chromium/src/+/6c146620037bf6c1222d5a0255be... Owners presubmit checks for files in components/resources are failing with an error like: File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry ('%s does not refer to an existing file.' % directive[5:])) owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file. TBR=jochen NOPRESUBMIT=true BUG= Review-Url: https://codereview.chromium.org/2913993003 Cr-Commit-Position: refs/heads/master@{#476369} Committed: https://chromium.googlesource.com/chromium/src/+/04b5424ac2e113a8ddbd18584b0e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/04b5424ac2e113a8ddbd18584b0e... |
