Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: src/compiler/effect-control-linearizer.cc

Issue 2913783002: [builtins] Begin removing CodeFactory accessors (Closed)
Patch Set: V8_EXPORT_PRIVATE Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/effect-control-linearizer.cc
diff --git a/src/compiler/effect-control-linearizer.cc b/src/compiler/effect-control-linearizer.cc
index b393aff726350227ce12f1bace8b00610c95b522..5c996356c8836cc1ebb7764f8852a2e8c814ab5c 100644
--- a/src/compiler/effect-control-linearizer.cc
+++ b/src/compiler/effect-control-linearizer.cc
@@ -2130,7 +2130,8 @@ Node* EffectControlLinearizer::LowerStringCharAt(Node* node) {
Node* receiver = node->InputAt(0);
Node* position = node->InputAt(1);
- Callable const callable = CodeFactory::StringCharAt(isolate());
+ Callable const callable =
+ Builtins::CallableFor(isolate(), Builtins::kStringCharAt);
Operator::Properties properties = Operator::kNoThrow | Operator::kNoWrite;
CallDescriptor::Flags flags = CallDescriptor::kNoFlags;
CallDescriptor* desc = Linkage::GetStubCallDescriptor(
@@ -2143,7 +2144,8 @@ Node* EffectControlLinearizer::LowerStringCharCodeAt(Node* node) {
Node* receiver = node->InputAt(0);
Node* position = node->InputAt(1);
- Callable const callable = CodeFactory::StringCharCodeAt(isolate());
+ Callable const callable =
+ Builtins::CallableFor(isolate(), Builtins::kStringCharCodeAt);
Operator::Properties properties = Operator::kNoThrow | Operator::kNoWrite;
CallDescriptor::Flags flags = CallDescriptor::kNoFlags;
CallDescriptor* desc = Linkage::GetStubCallDescriptor(
@@ -2382,16 +2384,18 @@ Node* EffectControlLinearizer::LowerStringComparison(Callable const& callable,
}
Node* EffectControlLinearizer::LowerStringEqual(Node* node) {
- return LowerStringComparison(CodeFactory::StringEqual(isolate()), node);
+ return LowerStringComparison(
+ Builtins::CallableFor(isolate(), Builtins::kStringEqual), node);
}
Node* EffectControlLinearizer::LowerStringLessThan(Node* node) {
- return LowerStringComparison(CodeFactory::StringLessThan(isolate()), node);
+ return LowerStringComparison(
+ Builtins::CallableFor(isolate(), Builtins::kStringLessThan), node);
}
Node* EffectControlLinearizer::LowerStringLessThanOrEqual(Node* node) {
- return LowerStringComparison(CodeFactory::StringLessThanOrEqual(isolate()),
- node);
+ return LowerStringComparison(
+ Builtins::CallableFor(isolate(), Builtins::kStringLessThanOrEqual), node);
}
Node* EffectControlLinearizer::LowerCheckFloat64Hole(Node* node,
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698