Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2913743004: Lowered size of bitmap for better GPU support (Closed)

Created:
3 years, 6 months ago by sugoi1
Modified:
3 years, 6 months ago
Reviewers:
dgozman, Eric Seckler
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Lowered size of bitmap for better GPU support - This test creates an SkBitmap, which can be texture backed. - Some GPUs have a maximum texture size of 8192, and so does the SwiftShader software renderer. - The test fails when the SkBitmap object exceeds the maximum texture size, which is probably not the goal of the test. - Lowered dimension from 10000 to 8192 in order to make sure the size isn't the reason the test fails. BUG=726075 Review-Url: https://codereview.chromium.org/2913743004 Cr-Commit-Position: refs/heads/master@{#475677} Committed: https://chromium.googlesource.com/chromium/src/+/819dc71b759fdeda4ff0f4255367cba0a1d3e5c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
sugoi1
On 2017/05/30 19:01:20, sugoi1 wrote: > mailto:sugoi@chromium.org changed reviewers: > + mailto:dgozman@chromium.org, mailto:eseckler@chromium.org This is ...
3 years, 6 months ago (2017-05-30 19:02:29 UTC) #3
dgozman
lgtm
3 years, 6 months ago (2017-05-30 21:08:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913743004/1
3 years, 6 months ago (2017-05-30 21:19:25 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 21:24:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/819dc71b759fdeda4ff0f4255367...

Powered by Google App Engine
This is Rietveld 408576698