Change the approach of front_end top level inference to match the spec.

Change the approach of front_end top level inference to match the spec.

Specifically, we can't walk all the subexpressions when doing top
level inference, or we will pick up bogus dependencies.  This means
that we can't determine the dependencies during BodyBuilder execution;
we have to do it in a follow-up pass once we have the AST.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0017ffd872ae21ab5e0bf6265dcb5acfd2febd11

[Paul Berry, 2017-05-30 17:54:33]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-05-30 18:07:05]

LGTM

https://codereview.chromium.org/2913743003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2913743003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:1148: //
TODO(paulberry): implement the proper logic here.
Leaf also asked me to create a version of Analyzer which allows instance getters
with annotated types. He was going to run it over internal codebase to make a
decision.

[Paul Berry, 2017-05-30 20:41:53]

https://codereview.chromium.org/2913743003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2913743003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:1148: //
TODO(paulberry): implement the proper logic here.
On 2017/05/30 18:07:05, scheglov wrote:
> Leaf also asked me to create a version of Analyzer which allows instance
getters
> with annotated types. He was going to run it over internal codebase to make a
> decision.

Thanks for the heads up!

[Paul Berry, 2017-05-30 20:42:15]

Description was changed from

==========
Change the approach of front_end top level inference to match the spec.

Specifically, we can't walk all the subexpressions when doing top
level inference, or we will pick up bogus dependencies.  This means
that we can't determine the dependencies during BodyBuilder execution;
we have to do it in a follow-up pass once we have the AST.
==========

to

==========
Change the approach of front_end top level inference to match the spec.

Specifically, we can't walk all the subexpressions when doing top
level inference, or we will pick up bogus dependencies.  This means
that we can't determine the dependencies during BodyBuilder execution;
we have to do it in a follow-up pass once we have the AST.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0017ffd872ae21ab5e0bf6265dcb5acfd2febd11
==========

[Paul Berry, 2017-05-30 20:42:16]

Committed patchset #1 (id:1) manually as
0017ffd872ae21ab5e0bf6265dcb5acfd2febd11 (presubmit successful).