Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2913743003: Change the approach of front_end top level inference to match the spec. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index ef900a0e723cf5d47c00941207b61a7462a2cd72..b53edd993a3dc14b74cb8cc6d7c9ede7621ae57a 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -15,9 +15,6 @@ import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart';
import 'package:front_end/src/fasta/kernel/utils.dart' show offsetForToken;
-import 'package:front_end/src/fasta/type_inference/type_inference_engine.dart'
- show FieldNode;
-
import 'package:front_end/src/fasta/type_inference/type_inferrer.dart'
show TypeInferrer;
@@ -94,11 +91,6 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
@override
final TypePromoter<Expression, VariableDeclaration> typePromoter;
- /// If not `null`, dependencies on fields are accumulated into this list.
- ///
- /// If `null`, no dependency information is recorded.
- final List<FieldNode> fieldDependencies;
-
/// Only used when [member] is a constructor. It tracks if an implicit super
/// initializer is needed.
///
@@ -147,8 +139,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
this.classBuilder,
this.isInstanceMember,
this.uri,
- this._typeInferrer,
- {this.fieldDependencies})
+ this._typeInferrer)
: enclosingScope = scope,
library = library,
enableNative = (library.uri.scheme == "dart" || library.isPatch),
@@ -2780,14 +2771,6 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
@override
StaticGet makeStaticGet(Member readTarget, Token token) {
- // TODO(paulberry): only record the dependencies mandated by the top level
- // type inference spec.
- if (fieldDependencies != null && readTarget is KernelField) {
- var fieldNode = _typeInferrer.getFieldNodeForReadTarget(readTarget);
- if (fieldNode != null) {
- fieldDependencies.add(fieldNode);
- }
- }
return new KernelStaticGet(readTarget)..fileOffset = offsetForToken(token);
}
}

Powered by Google App Engine
This is Rietveld 408576698