Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2913743002: DebugVisualizers: Blink rename follow up and LayoutNG additions (Closed)

Created:
3 years, 6 months ago by kojii
Modified:
3 years, 6 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DebugVisualizers: Blink rename follow up and LayoutNG additions This patch supports minor follow up Blink Rename, and adds two LayoutNG commonly used classes. Tested on VS2015/2017 with natvis diagnostic messages turned on. Review-Url: https://codereview.chromium.org/2913743002 Cr-Commit-Position: refs/heads/master@{#475729} Committed: https://chromium.googlesource.com/chromium/src/+/fcbbb5f35592867b2c274348c9c83807c58001c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M tools/win/DebugVisualizers/webkit.natvis View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
kojii
PTAL.
3 years, 6 months ago (2017-05-30 07:14:19 UTC) #6
brucedawson
lgtm
3 years, 6 months ago (2017-05-30 23:40:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913743002/1
3 years, 6 months ago (2017-05-31 01:37:37 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 01:42:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fcbbb5f35592867b2c274348c9c8...

Powered by Google App Engine
This is Rietveld 408576698