Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2913723002: Generate enum/getters/setters/mappings for text-orientation. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index b4ff29563af867d87489ae80c6c83e6772b4973f..08d14187062340917fd5cf0ae27a443e03a74d53 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -1603,41 +1603,6 @@ inline TextEmphasisMark CSSIdentifierValue::ConvertTo() const {
}
template <>
-inline CSSIdentifierValue::CSSIdentifierValue(TextOrientation e)
- : CSSValue(kIdentifierClass) {
- switch (e) {
- case TextOrientation::kSideways:
- value_id_ = CSSValueSideways;
- break;
- case TextOrientation::kMixed:
- value_id_ = CSSValueMixed;
- break;
- case TextOrientation::kUpright:
- value_id_ = CSSValueUpright;
- break;
- }
-}
-
-template <>
-inline TextOrientation CSSIdentifierValue::ConvertTo() const {
- switch (value_id_) {
- case CSSValueSideways:
- case CSSValueSidewaysRight:
shend 2017/05/30 20:48:43 Special case here, gotta override it in CSSValueID
nainar 2017/05/31 03:59:57 Done.
- return TextOrientation::kSideways;
- case CSSValueMixed:
- case CSSValueVerticalRight: // -webkit-text-orientation
shend 2017/05/30 20:48:43 Same here.
nainar 2017/05/31 03:59:57 Done.
- return TextOrientation::kMixed;
- case CSSValueUpright:
- return TextOrientation::kUpright;
- default:
- break;
- }
-
- NOTREACHED();
- return TextOrientation::kMixed;
-}
-
-template <>
inline CSSIdentifierValue::CSSIdentifierValue(FontDescription::Kerning kerning)
: CSSValue(kIdentifierClass) {
switch (kerning) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698