Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2913663004: MacViews: Fix mac_views_browser compilation due to unused variable on Mac. (Closed)

Created:
3 years, 6 months ago by Patti Lor
Modified:
3 years, 6 months ago
Reviewers:
tapted, msw
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix mac_views_browser compilation due to unused variable on Mac. AvatarButton declares a variable that is only used on Win/Linux. This breaks the MacViews browser compile (mac_views_browser=true in gn), so fix it by declaring the same variable inside both #ifdef branches in which it's used. BUG=425229 Review-Url: https://codereview.chromium.org/2913663004 Cr-Commit-Position: refs/heads/master@{#476120} Committed: https://chromium.googlesource.com/chromium/src/+/83ad1eda722e5e35b9d0a943617036958c6b4b4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/profiles/avatar_button.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Patti Lor
Hey Trent, is this fix OK? Thanks!
3 years, 6 months ago (2017-05-31 06:56:49 UTC) #8
tapted
lgtm
3 years, 6 months ago (2017-05-31 07:01:32 UTC) #9
Patti Lor
Hi msw@, PTAL for owner's review? Thanks.
3 years, 6 months ago (2017-05-31 07:07:07 UTC) #11
msw
lgtm
3 years, 6 months ago (2017-05-31 14:19:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913663004/1
3 years, 6 months ago (2017-06-01 01:01:21 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 01:06:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83ad1eda722e5e35b9d0a9436170...

Powered by Google App Engine
This is Rietveld 408576698