Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2913653002: Move more standalone files from web/ to core/exported/. (Closed)

Created:
3 years, 6 months ago by slangley
Modified:
3 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more standalone files from web/ to core/exported/. Some methods needed to be marked BLINK_EXPORT in WebPageImportanceSignals so they were visible from libblink_core and could be linked against. BUG=712963 Review-Url: https://codereview.chromium.org/2913653002 Cr-Commit-Position: refs/heads/master@{#475414} Committed: https://chromium.googlesource.com/chromium/src/+/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d

Patch Set 1 #

Patch Set 2 : Move files to the right directory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -244 lines) Patch
M third_party/WebKit/Source/core/exported/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebPageImportanceSignals.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebPluginScriptForbiddenScope.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebScopedUserGesture.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebUserGestureIndicator.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebUserGestureToken.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/web/WebPageImportanceSignals.cpp View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/web/WebPluginScriptForbiddenScope.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/Source/web/WebScopedUserGesture.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/web/WebUserGestureIndicator.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/web/WebUserGestureToken.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
M third_party/WebKit/public/web/WebPageImportanceSignals.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
slangley
3 years, 6 months ago (2017-05-30 00:08:09 UTC) #9
haraken
LGTM
3 years, 6 months ago (2017-05-30 00:52:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913653002/20001
3 years, 6 months ago (2017-05-30 01:41:56 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 03:13:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4203fb9fe1e588b6932448b0b4e7...

Powered by Google App Engine
This is Rietveld 408576698