Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2913643002: Animate ink drop to HIDDEN when showing the context menu. (Closed)

Created:
3 years, 6 months ago by bruthig
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, David Trainor- moved to gerrit, dbeam+watch-downloads_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ui] Hide the ink highlight on the download bar when showing a context menu. BUG=615013 TEST=manual Review-Url: https://codereview.chromium.org/2913643002 Cr-Commit-Position: refs/heads/master@{#475590} Committed: https://chromium.googlesource.com/chromium/src/+/5dc1f110c5a1fc9fab3e79a83206000bf0aa61e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/views/download/download_item_view.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
bruthig
sky@, can you take a quick look?
3 years, 6 months ago (2017-05-29 20:29:37 UTC) #5
sky
LGTM
3 years, 6 months ago (2017-05-30 16:45:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913643002/1
3 years, 6 months ago (2017-05-30 17:46:42 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 17:52:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5dc1f110c5a1fc9fab3e79a83206...

Powered by Google App Engine
This is Rietveld 408576698