Forward BrowserAccessibility accSelect() to AXPlatformNode.

Forward BrowserAccessibility accSelect() to AXPlatformNode.

This forwards accSelect to the AXPlatformNode. In order to do this, we
had to extension AccessibilityPerformAction a bit to be able to handle
AX_ACTION_FOCUS. Not that the node id is not passed as part of the AXActionData
and is not being used by the delegate at this point.

BUG=703369
Review-Url: https://codereview.chromium.org/2913553003
Cr-Commit-Position: refs/heads/master@{#475806}
Committed: https://chromium.googlesource.com/chromium/src/+/9570c41a05e2556411722bf15da9f527ccaaa646

[dougt, 2017-05-29 03:34:50]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 03:35:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-05-29 04:26:22]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 04:26:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-05-29 05:09:18]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dougt, 2017-05-29 05:09:19]

ptal.

[commit-bot: I haz the power, 2017-05-29 05:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 05:20:07]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-05-30 15:24:05]

lgtm

https://codereview.chromium.org/2913553003/diff/20001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.cc (right):

https://codereview.chromium.org/2913553003/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.cc:556:
action_data.target_node_id = unique_id_;
Wrong id - this should be GetData().id() - but actually it's not needed
either way since we're calling it on a specific object, so
BrowserAccessibilityManager sets the id before forwarding the
action to the renderer

...so delete it for now, but in general be careful about node id
vs unique id

The unique id is only for the browser process, the node id is
unique within a frame and used for communicating actions to
the render process

[dougt, 2017-05-31 00:55:19]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[dougt, 2017-05-31 00:55:59]

Description was changed from

==========
Forward BrowserAccessibility accSelect() to AXPlatformNode.

This forwards accSelect to the AXPlatformNode. In order to do this, we
had to extension AccessibilityPerformAction a bit to be able to handle
AX_ACTION_FOCUS. Not that the node id is passed as part of the AXActionData
but it is not being used by the delegate at this point.

BUG=703369
==========

to

==========
Forward BrowserAccessibility accSelect() to AXPlatformNode.

This forwards accSelect to the AXPlatformNode. In order to do this, we
had to extension AccessibilityPerformAction a bit to be able to handle
AX_ACTION_FOCUS. Not that the node id is not passed as part of the AXActionData
and is not being used by the delegate at this point.

BUG=703369
==========

[commit-bot: I haz the power, 2017-05-31 00:56:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 02:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 02:22:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dougt, 2017-05-31 02:45:43]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-05-31 02:45:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2913553003/#ps40001
(title: "Drop passing node id to AccessibilityPerformAction")

[commit-bot: I haz the power, 2017-05-31 02:46:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 04:46:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496198743124880,
"parent_rev": "9a9457b324f2f57511d6a1cd9a00a86b7f96837c", "commit_rev":
"9570c41a05e2556411722bf15da9f527ccaaa646"}

[commit-bot: I haz the power, 2017-05-31 04:46:11]

Description was changed from

==========
Forward BrowserAccessibility accSelect() to AXPlatformNode.

This forwards accSelect to the AXPlatformNode. In order to do this, we
had to extension AccessibilityPerformAction a bit to be able to handle
AX_ACTION_FOCUS. Not that the node id is not passed as part of the AXActionData
and is not being used by the delegate at this point.

BUG=703369
==========

to

==========
Forward BrowserAccessibility accSelect() to AXPlatformNode.

This forwards accSelect to the AXPlatformNode. In order to do this, we
had to extension AccessibilityPerformAction a bit to be able to handle
AX_ACTION_FOCUS. Not that the node id is not passed as part of the AXActionData
and is not being used by the delegate at this point.

BUG=703369

Review-Url: https://codereview.chromium.org/2913553003
Cr-Commit-Position: refs/heads/master@{#475806}
Committed:
https://chromium.googlesource.com/chromium/src/+/9570c41a05e2556411722bf15da9...
==========

[commit-bot: I haz the power, 2017-05-31 04:46:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9570c41a05e2556411722bf15da9...