Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2913513002: Remove unused methods in SVGListPropertyHelper and SVGPropertyTearOff* (Closed)

Created:
3 years, 6 months ago by fs
Modified:
3 years, 6 months ago
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused methods in SVGListPropertyHelper and SVGPropertyTearOff* SVGPropertyTearOffBase: :GetType, and corresponding concretization in Review-Url: https://codereview.chromium.org/2913513002 Cr-Commit-Position: refs/heads/master@{#475310} Committed: https://chromium.googlesource.com/chromium/src/+/757e4d09bfd9910c6aba736f8ae437d4da0a25c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 6 months ago (2017-05-28 20:26:11 UTC) #4
kouhei (in TOK)
lgtm Thanks for the clean up!
3 years, 6 months ago (2017-05-29 05:37:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913513002/1
3 years, 6 months ago (2017-05-29 08:19:57 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 08:23:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/757e4d09bfd9910c6aba736f8ae4...

Powered by Google App Engine
This is Rietveld 408576698