Fix scheme check in SiteInstance::IsSameWebSite for nested URLs.

content/browser/site_instance_impl_unittest.cc

Index: content/browser/site_instance_impl_unittest.cc
diff --git a/content/browser/site_instance_impl_unittest.cc b/content/browser/site_instance_impl_unittest.cc
index 845c274b86e51f55078d2fa4c5d0bba7220a02ed..e29a1ee54c6c460ec5f40def704d446f9756208b 100644
--- a/content/browser/site_instance_impl_unittest.cc
+++ b/content/browser/site_instance_impl_unittest.cc
@@ -794,6 +794,33 @@ TEST_F(SiteInstanceTest, NoProcessPerSiteForEmptySite) {
   DrainMessageLoop();
 }
 
+// Check that an URL is considered same-site with blob: and filesystem: URLs
+// with a matching inner origin.  See https://crbug.com/726370.
+TEST_F(SiteInstanceTest, IsSameWebsiteForNestedURLs) {
+  GURL foo_url("http://foo.com/");
+  GURL bar_url("http://bar.com/");
+  GURL blob_foo_url("blob:http://foo.com/uuid");
+  GURL blob_bar_url("blob:http://bar.com/uuid");
+  GURL fs_foo_url("filesystem:http://foo.com/path/");
+  GURL fs_bar_url("filesystem:http://bar.com/path/");

[ncarter (slow), 2017/05/31 17:32:54]

This test maybe ought to exercise a case with www.bar.com as the host; something
that ensures we're actually doing the comparison on the ETLD+1.

[alexmos, 2017/05/31 23:02:26]

Done.  Also added a case to make sure the inner scheme is also used in the
comparison.

+
+  EXPECT_TRUE(SiteInstance::IsSameWebSite(nullptr, foo_url, blob_foo_url));
+  EXPECT_TRUE(SiteInstance::IsSameWebSite(nullptr, blob_foo_url, foo_url));
+  EXPECT_FALSE(SiteInstance::IsSameWebSite(nullptr, foo_url, blob_bar_url));
+  EXPECT_FALSE(SiteInstance::IsSameWebSite(nullptr, blob_foo_url, bar_url));
+
+  EXPECT_TRUE(SiteInstance::IsSameWebSite(nullptr, foo_url, fs_foo_url));
+  EXPECT_TRUE(SiteInstance::IsSameWebSite(nullptr, fs_foo_url, foo_url));
+  EXPECT_FALSE(SiteInstance::IsSameWebSite(nullptr, foo_url, fs_bar_url));
+  EXPECT_FALSE(SiteInstance::IsSameWebSite(nullptr, fs_foo_url, bar_url));
+
+  EXPECT_TRUE(SiteInstance::IsSameWebSite(nullptr, blob_foo_url, fs_foo_url));
+  EXPECT_FALSE(SiteInstance::IsSameWebSite(nullptr, blob_foo_url, fs_bar_url));
+  EXPECT_FALSE(
+      SiteInstance::IsSameWebSite(nullptr, blob_foo_url, blob_bar_url));
+  EXPECT_FALSE(SiteInstance::IsSameWebSite(nullptr, fs_foo_url, fs_bar_url));
+}
+
 TEST_F(SiteInstanceTest, DefaultSubframeSiteInstance) {
   if (AreAllSitesIsolatedForTesting())
     return;  // --top-document-isolation is not possible.