Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2913443002:
Fix scheme check in SiteInstance::IsSameWebSite for nested URLs. (Closed)
|
Created:
3 years, 7 months ago by alexmos Modified:
3 years, 6 months ago Reviewers:
ncarter (slow) CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, jam, ajwong+watch_chromium.org, site-isolation-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix scheme check in SiteInstance::IsSameWebSite for nested URLs.
BUG=726370
Review-Url: https://codereview.chromium.org/2913443002
Cr-Commit-Position: refs/heads/master@{#476164}
Committed: https://chromium.googlesource.com/chromium/src/+/cbf99578af94e8d3e95ac8da4ee10d0689e20993
Patch Set 1 #
Total comments: 2
Patch Set 2 : Nick's comments #
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by alexmos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by alexmos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
alexmos@chromium.org changed reviewers: + nick@chromium.org
Nick, can you please take a look?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2913443002/diff/1/content/browser/site_instan... File content/browser/site_instance_impl_unittest.cc (right): https://codereview.chromium.org/2913443002/diff/1/content/browser/site_instan... content/browser/site_instance_impl_unittest.cc:805: GURL fs_bar_url("filesystem:http://bar.com/path/"); This test maybe ought to exercise a case with www.bar.com as the host; something that ensures we're actually doing the comparison on the ETLD+1.
https://codereview.chromium.org/2913443002/diff/1/content/browser/site_instan... File content/browser/site_instance_impl_unittest.cc (right): https://codereview.chromium.org/2913443002/diff/1/content/browser/site_instan... content/browser/site_instance_impl_unittest.cc:805: GURL fs_bar_url("filesystem:http://bar.com/path/"); On 2017/05/31 17:32:54, ncarter (slow) wrote: > This test maybe ought to exercise a case with http://www.bar.com as the host; something > that ensures we're actually doing the comparison on the ETLD+1. Done. Also added a case to make sure the inner scheme is also used in the comparison.
The CQ bit was checked by alexmos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org Link to the patchset: https://codereview.chromium.org/2913443002/#ps20001 (title: "Nick's comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alexmos@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496283428112280,
"parent_rev": "0df7ba19a1894044729cdc73bc695a4e9edc3f3c", "commit_rev":
"cbf99578af94e8d3e95ac8da4ee10d0689e20993"}
Message was sent while issue was closed.
Description was changed from ========== Fix scheme check in SiteInstance::IsSameWebSite for nested URLs. BUG=726370 ========== to ========== Fix scheme check in SiteInstance::IsSameWebSite for nested URLs. BUG=726370 Review-Url: https://codereview.chromium.org/2913443002 Cr-Commit-Position: refs/heads/master@{#476164} Committed: https://chromium.googlesource.com/chromium/src/+/cbf99578af94e8d3e95ac8da4ee1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/cbf99578af94e8d3e95ac8da4ee1... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
