Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2913403002: Move ScrollSnapPoints to its own file. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScrollSnapPoints to its own file. This patch moves ScrollSnapPoints to its own file so that we do not lose its definition when we generate StyleScrollSnapData. BUG=628043 Review-Url: https://codereview.chromium.org/2913403002 Cr-Commit-Position: refs/heads/master@{#476561} Committed: https://chromium.googlesource.com/chromium/src/+/4dd1ce7526c926a0a05909a90cc303f56d29c26f

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M third_party/WebKit/Source/core/style/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/style/ScrollSnapPoints.h View 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleScrollSnapData.h View 2 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleScrollSnapData.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 25 (21 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-06-02 00:42:46 UTC) #15
meade_UTC10
lgtm
3 years, 6 months ago (2017-06-02 04:05:08 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913403002/20001
3 years, 6 months ago (2017-06-02 04:17:51 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 04:23:44 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4dd1ce7526c926a0a05909a90cc3...

Powered by Google App Engine
This is Rietveld 408576698