Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2913393002: Only show grouped permission bubbles for mic/camera permissions (Closed)

Created:
3 years, 6 months ago by raymes
Modified:
3 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only show grouped permission bubbles for mic/camera permissions This changes the desktop grouped permission bubble behavior such that we never show grouped permission prompts, accept in the case of mic/camers. All other permission prompts will be displayed sequentially. Testing is added for these cases. BUG=728483 Review-Url: https://codereview.chromium.org/2913393002 Cr-Commit-Position: refs/heads/master@{#476942} Committed: https://chromium.googlesource.com/chromium/src/+/55f9320b2d675e4b008597fd269d102e1d4d3b00

Patch Set 1 #

Patch Set 2 : Remove grouped requests #

Patch Set 3 : Remove grouped requests #

Patch Set 4 : Remove grouped requests #

Messages

Total messages: 20 (16 generated)
raymes
3 years, 6 months ago (2017-06-01 05:04:06 UTC) #2
Timothy Loh
On 2017/06/01 05:04:06, raymes wrote: lgtm!
3 years, 6 months ago (2017-06-05 04:18:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913393002/60001
3 years, 6 months ago (2017-06-05 04:52:04 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 04:55:51 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/55f9320b2d675e4b008597fd269d...

Powered by Google App Engine
This is Rietveld 408576698