Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2913353004: MIPS[64]: Add support for big endian build using GN (Closed)

Created:
3 years, 6 months ago by sreten.kovacevic
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Add support for big endian build using GN Chromium_BUG=616017 R=machenbach@chromium.org, dpranke@chromium.org, ivica.bogosavljevic@imgtec.com Review-Url: https://codereview.chromium.org/2913353004 Cr-Commit-Position: refs/heads/master@{#45691} Committed: https://chromium.googlesource.com/v8/v8/+/64a6059918c32fe64a79561d1ef85c0090f7ddf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M BUILD.gn View 2 chunks +7 lines, -6 lines 0 comments Download
M snapshot_toolchain.gni View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sreten.kovacevic
PTAL
3 years, 6 months ago (2017-06-01 13:47:24 UTC) #2
Michael Achenbach
lgtm
3 years, 6 months ago (2017-06-02 13:03:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913353004/1
3 years, 6 months ago (2017-06-02 15:01:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/64a6059918c32fe64a79561d1ef85c0090f7ddf4
3 years, 6 months ago (2017-06-02 15:02:26 UTC) #13
Dirk Pranke
3 years, 6 months ago (2017-06-07 02:08:08 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698