Implementation of sync password hash clearing.

Implementation of sync password hash clearing.

Also it's added test for checking that saving/clearing sync password hash.

BUG=657041
Review-Url: https://codereview.chromium.org/2913323004
Cr-Commit-Position: refs/heads/master@{#476633}
Committed: https://chromium.googlesource.com/chromium/src/+/10e549c89401c60b133d6fa29464a55349c3bcaf

[dvadym, 2017-06-01 15:42:41]

Description was changed from

==========
clear hash

BUG=657041
==========

to

==========
Clear sync password hash.

Also it's added test for checking that saving/clearing sync password hash.

BUG=657041
==========

[dvadym, 2017-06-01 15:42:41]

dvadym@chromium.org changed reviewers:
+ vasilii@chromium.org

[dvadym, 2017-06-01 15:43:00]

Description was changed from

==========
Clear sync password hash.

Also it's added test for checking that saving/clearing sync password hash.

BUG=657041
==========

to

==========
Implementation of clear sync password hash.

Also it's added test for checking that saving/clearing sync password hash.

BUG=657041
==========

[dvadym, 2017-06-01 15:47:04]

Hi Vasilii,

could you please review this CL?

Regards,
Vadym

[dvadym, 2017-06-01 15:51:08]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 15:51:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvadym, 2017-06-01 15:52:47]

Description was changed from

==========
Implementation of clear sync password hash.

Also it's added test for checking that saving/clearing sync password hash.

BUG=657041
==========

to

==========
Implementation of sync password hash clearing.

Also it's added test for checking that saving/clearing sync password hash.

BUG=657041
==========

[commit-bot: I haz the power, 2017-06-01 16:58:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 16:58:44]

Dry run: This issue passed the CQ dry run.

[vasilii, 2017-06-02 09:30:58]

https://codereview.chromium.org/2913323004/diff/40001/components/password_man...
File components/password_manager/core/browser/password_store_unittest.cc
(right):

https://codereview.chromium.org/2913323004/diff/40001/components/password_man...
components/password_manager/core/browser/password_store_unittest.cc:979:
OSCryptMocker::SetUpWithSingleton();
Why don't you put it into the test setup instead of copy/pasting everywhere?
I think all the tests in the file need it.

https://codereview.chromium.org/2913323004/diff/40001/components/password_man...
components/password_manager/core/browser/password_store_unittest.cc:994:
OnReuseFound(sync_password, "accounts.google.com", 1, 0));
How can the consumer get the plain-text sync password if we store internally
only hash?
Is it just a substring of |input|?

[dvadym, 2017-06-02 09:53:14]

https://codereview.chromium.org/2913323004/diff/40001/components/password_man...
File components/password_manager/core/browser/password_store_unittest.cc
(right):

https://codereview.chromium.org/2913323004/diff/40001/components/password_man...
components/password_manager/core/browser/password_store_unittest.cc:979:
OSCryptMocker::SetUpWithSingleton();
On 2017/06/02 09:30:58, vasilii wrote:
> Why don't you put it into the test setup instead of copy/pasting everywhere?
> I think all the tests in the file need it.

Thanks, it makes perfect sense. Done

https://codereview.chromium.org/2913323004/diff/40001/components/password_man...
components/password_manager/core/browser/password_store_unittest.cc:994:
OnReuseFound(sync_password, "accounts.google.com", 1, 0));
On 2017/06/02 09:30:58, vasilii wrote:
> How can the consumer get the plain-text sync password if we store internally
> only hash?
> Is it just a substring of |input|?

Yes, it's substring of input, which hash is equal to the sync password hash.

[dvadym, 2017-06-02 09:53:19]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 09:53:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2017-06-02 10:04:42]

lgtm

[dvadym, 2017-06-02 10:09:03]

The CQ bit was unchecked by dvadym@chromium.org

[dvadym, 2017-06-02 10:09:03]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-06-02 10:09:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 12:21:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 12:21:33]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dvadym, 2017-06-02 12:22:00]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-06-02 12:22:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 14:04:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496406120609580,
"parent_rev": "c0cdd99d33f708afb6ba0a7694482b4bdffbbaeb", "commit_rev":
"10e549c89401c60b133d6fa29464a55349c3bcaf"}

[commit-bot: I haz the power, 2017-06-02 14:04:47]

Description was changed from

==========
Implementation of sync password hash clearing.

Also it's added test for checking that saving/clearing sync password hash.

BUG=657041
==========

to

==========
Implementation of sync password hash clearing.

Also it's added test for checking that saving/clearing sync password hash.

BUG=657041

Review-Url: https://codereview.chromium.org/2913323004
Cr-Commit-Position: refs/heads/master@{#476633}
Committed:
https://chromium.googlesource.com/chromium/src/+/10e549c89401c60b133d6fa29464...
==========

[commit-bot: I haz the power, 2017-06-02 14:04:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/10e549c89401c60b133d6fa29464...