Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2913313002: Tether: Persist if first-time setup is required to HostScanCache. (Closed)

Created:
3 years, 6 months ago by Ryan Hansberry
Modified:
3 years, 6 months ago
Reviewers:
Kyle Horimoto
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Tether: Persist if first-time setup is required to HostScanCache. BUG=672263 Review-Url: https://codereview.chromium.org/2913313002 Cr-Commit-Position: refs/heads/master@{#476140} Committed: https://chromium.googlesource.com/chromium/src/+/387dc454ec4618108b33925bde37c083ae3e8d55

Patch Set 1 #

Patch Set 2 : khorimoto@ comments. #

Total comments: 6

Patch Set 3 : Rebase. #

Patch Set 4 : khorimoto@ comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -18 lines) Patch
M chromeos/components/tether/fake_host_scan_cache.h View 2 chunks +4 lines, -1 line 0 comments Download
M chromeos/components/tether/fake_host_scan_cache.cc View 1 3 chunks +15 lines, -4 lines 0 comments Download
M chromeos/components/tether/host_scan_cache.h View 1 2 3 3 chunks +10 lines, -1 line 0 comments Download
M chromeos/components/tether/host_scan_cache.cc View 1 2 4 chunks +14 lines, -1 line 0 comments Download
M chromeos/components/tether/host_scan_cache_unittest.cc View 1 2 3 8 chunks +23 lines, -8 lines 0 comments Download
M chromeos/components/tether/host_scanner.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/components/tether/host_scanner_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ryan Hansberry
3 years, 6 months ago (2017-05-31 22:52:01 UTC) #3
Kyle Horimoto
LGTM assuming that you figured out the test issue. https://codereview.chromium.org/2913313002/diff/20001/chromeos/components/tether/host_scan_cache.cc File chromeos/components/tether/host_scan_cache.cc (right): https://codereview.chromium.org/2913313002/diff/20001/chromeos/components/tether/host_scan_cache.cc#newcode90 chromeos/components/tether/host_scan_cache.cc:90: ...
3 years, 6 months ago (2017-05-31 23:01:19 UTC) #4
Ryan Hansberry
https://codereview.chromium.org/2913313002/diff/20001/chromeos/components/tether/host_scan_cache.cc File chromeos/components/tether/host_scan_cache.cc (right): https://codereview.chromium.org/2913313002/diff/20001/chromeos/components/tether/host_scan_cache.cc#newcode90 chromeos/components/tether/host_scan_cache.cc:90: if (setup_required) On 2017/05/31 23:01:19, Kyle Horimoto wrote: > ...
3 years, 6 months ago (2017-06-01 01:07:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913313002/50001
3 years, 6 months ago (2017-06-01 01:08:55 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 01:50:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/387dc454ec4618108b33925bde37...

Powered by Google App Engine
This is Rietveld 408576698