Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 2913243002: Revert of Toggle DocumentsUI on/off using ChromeOS flag.

Created:
3 years, 6 months ago by Ben Lin
Modified:
3 years, 6 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Toggle DocumentsUI on/off using ChromeOS flag. (patchset #1 id:1 of https://codereview.chromium.org/2804703003/ ) Reason for revert: Prebundled DocumentsUI no longer being include. Original issue's description: > Toggle DocumentsUI on/off using ChromeOS flag. > > Test=manual > BUG=34847872 > > Review-Url: https://codereview.chromium.org/2804703003 > Cr-Commit-Position: refs/heads/master@{#463425} > Committed: https://chromium.googlesource.com/chromium/src/+/eb85d566226621ba40a61a3e10fa7d6aeae091ad TBR=hirono@chromium.org,xutan@chromium.org,smckay@chromium.org,stevenjb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=34847872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ben Lin
Created Revert of Toggle DocumentsUI on/off using ChromeOS flag.
3 years, 6 months ago (2017-05-31 18:35:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913243002/1
3 years, 6 months ago (2017-05-31 18:36:19 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-05-31 18:36:22 UTC) #5
xutan
3 years, 6 months ago (2017-05-31 22:06:36 UTC) #6
Actually https://codereview.chromium.org/2917773002/ already contains this so
there is probably no need for this. That won't compile without this change.

Powered by Google App Engine
This is Rietveld 408576698