Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2804703003: Toggle DocumentsUI on/off using ChromeOS flag. (Closed)

Created:
3 years, 8 months ago by Ben Lin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Toggle DocumentsUI on/off using ChromeOS flag. Test=manual BUG=34847872 Review-Url: https://codereview.chromium.org/2804703003 Cr-Commit-Position: refs/heads/master@{#463425} Committed: https://chromium.googlesource.com/chromium/src/+/eb85d566226621ba40a61a3e10fa7d6aeae091ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Ben Lin
3 years, 8 months ago (2017-04-05 22:04:50 UTC) #2
hirono
lgtm! Please add TEST= line to commit message before committing. Thank you!
3 years, 8 months ago (2017-04-10 06:34:09 UTC) #3
stevenjb
owner lgtm
3 years, 8 months ago (2017-04-10 17:25:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804703003/1
3 years, 8 months ago (2017-04-10 21:54:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/eb85d566226621ba40a61a3e10fa7d6aeae091ad
3 years, 8 months ago (2017-04-10 22:42:41 UTC) #12
Ben Lin
3 years, 6 months ago (2017-05-31 18:35:03 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2913243002/ by linben@chromium.org.

The reason for reverting is: Prebundled DocumentsUI no longer being include..

Powered by Google App Engine
This is Rietveld 408576698