Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2913233003: Move fixed point constants from ComputedStyleConstants to BorderValue. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move fixed point constants from ComputedStyleConstants to BorderValue. This patch moves these constants because they are no longer used by ComputedStyle nor ComputedStyleBase, but only by BorderValue. BUG=628043 Review-Url: https://codereview.chromium.org/2913233003 Cr-Commit-Position: refs/heads/master@{#476602} Committed: https://chromium.googlesource.com/chromium/src/+/e7c31a19402ec496651ee9c6b0177234fda7d600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/BorderValue.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
shend
Hi Naina, PTAL
3 years, 6 months ago (2017-06-01 00:22:42 UTC) #4
nainar
lgtm
3 years, 6 months ago (2017-06-01 00:25:07 UTC) #5
shend
Hi Alan, PTAL
3 years, 6 months ago (2017-06-01 01:48:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913233003/1
3 years, 6 months ago (2017-06-02 08:34:01 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 08:37:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7c31a19402ec496651ee9c6b017...

Powered by Google App Engine
This is Rietveld 408576698