[step_runner] run _merge_envs in simulation too.

[step_runner] run _merge_envs in simulation too.

This should catch envvar %-formatting weirdness much earlier.

R=dnj@chromium.org, nodir@chromium.org
BUG=727493
Review-Url: https://codereview.chromium.org/2913203002
Committed: https://github.com/luci/recipes-py/commit/458ce956c9d91d184e0107c5fa6b34a8267b8e9b

[iannucci, 2017-05-31 17:39:33]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 17:39:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 17:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 17:52:26]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3678691fc56c6f10)

[iannucci, 2017-05-31 21:15:39]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 21:15:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:19:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:19:24]

Dry run: This issue passed the CQ dry run.

[nodir, 2017-05-31 21:49:03]

https://codereview.chromium.org/2913203002/diff/1/recipe_engine/step_runner.py
File recipe_engine/step_runner.py (right):

https://codereview.chromium.org/2913203002/diff/1/recipe_engine/step_runner.p...
recipe_engine/step_runner.py:409: class fakeEnviron(object):
when reading this without context, it is hard to understand what's the
purpose/responsibility of this class. Please maybe add comments explaining what
you explained offline :)

https://codereview.chromium.org/2913203002/diff/1/recipe_modules/context/api.py
File recipe_modules/context/api.py (right):

https://codereview.chromium.org/2913203002/diff/1/recipe_modules/context/api....
recipe_modules/context/api.py:147: v % collections.defaultdict(str)
it does not fail for v==`%s'

[iannucci, 2017-05-31 21:56:14]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 21:56:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nodir, 2017-05-31 21:58:41]

lgtm

a comment for fakeEnv would be still nice

https://codereview.chromium.org/2913203002/diff/20001/recipe_modules/context/...
File recipe_modules/context/api.py (right):

https://codereview.chromium.org/2913203002/diff/20001/recipe_modules/context/...
recipe_modules/context/api.py:156: ("%(foo)s"+v) % collections.defaultdict(str)
use ' ?

[commit-bot: I haz the power, 2017-05-31 21:59:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:59:34]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-05-31 22:07:44]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-05-31 22:07:45]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2913203002/#ps40001
(title: "quotes and comments")

[iannucci, 2017-05-31 22:07:55]

https://codereview.chromium.org/2913203002/diff/1/recipe_modules/context/api.py
File recipe_modules/context/api.py (right):

https://codereview.chromium.org/2913203002/diff/1/recipe_modules/context/api....
recipe_modules/context/api.py:147: v % collections.defaultdict(str)
On 2017/05/31 21:49:03, nodir wrote:
> it does not fail for v==`%s'

Done.

https://codereview.chromium.org/2913203002/diff/20001/recipe_modules/context/...
File recipe_modules/context/api.py (right):

https://codereview.chromium.org/2913203002/diff/20001/recipe_modules/context/...
recipe_modules/context/api.py:156: ("%(foo)s"+v) % collections.defaultdict(str)
On 2017/05/31 21:58:41, nodir wrote:
> use ' ?

Done.

[commit-bot: I haz the power, 2017-05-31 22:07:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 22:10:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496268464441490,
"parent_rev": "8d7bd42ec1713294cf6cb36127c96a1f439f9419", "commit_rev":
"458ce956c9d91d184e0107c5fa6b34a8267b8e9b"}

[commit-bot: I haz the power, 2017-05-31 22:10:30]

Description was changed from

==========
[step_runner] run _merge_envs in simulation too.

This should catch envvar %-formatting weirdness much earlier.

R=dnj@chromium.org, nodir@chromium.org
BUG=727493
==========

to

==========
[step_runner] run _merge_envs in simulation too.

This should catch envvar %-formatting weirdness much earlier.

R=dnj@chromium.org, nodir@chromium.org
BUG=727493

Review-Url: https://codereview.chromium.org/2913203002
Committed:
https://github.com/luci/recipes-py/commit/458ce956c9d91d184e0107c5fa6b34a8267...
==========

[commit-bot: I haz the power, 2017-05-31 22:10:31]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/458ce956c9d91d184e0107c5fa6b34a8267...