Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 291303003: Eliminate MediaPlayer & MediaPlayerClient abstractions (fullscreen apis) (Closed)

Created:
6 years, 7 months ago by Srirama
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, krit, philipj_slow, jbroman, eric.carlson_apple.com, danakj, feature-media-reviews_chromium.org, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Eliminate MediaPlayer & MediaPlayerClient abstractions BUG=350571 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174940

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M Source/platform/graphics/media/MediaPlayer.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/FullscreenController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Srirama
Removed fullscreen related APIs. PTAL.
6 years, 7 months ago (2014-05-21 06:39:17 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 7 months ago (2014-05-22 01:08:28 UTC) #2
Srirama
The CQ bit was checked by srirama.m@samsung.com
6 years, 7 months ago (2014-05-22 05:14:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srirama.m@samsung.com/291303003/1
6 years, 7 months ago (2014-05-22 05:16:01 UTC) #4
Srirama
The CQ bit was unchecked by srirama.m@samsung.com
6 years, 7 months ago (2014-05-22 07:50:06 UTC) #5
Srirama
The CQ bit was checked by srirama.m@samsung.com
6 years, 7 months ago (2014-05-22 07:50:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srirama.m@samsung.com/291303003/1
6 years, 7 months ago (2014-05-22 07:50:40 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 17:17:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 17:18:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9782)
6 years, 7 months ago (2014-05-22 17:18:49 UTC) #10
acolwell GONE FROM CHROMIUM
adamk@: Owners review for web/ and platform/ changes please.
6 years, 7 months ago (2014-05-22 18:00:47 UTC) #11
Srirama
On 2014/05/22 18:00:47, acolwell_OOO_5-24_to_5-30 wrote: > adamk@: Owners review for web/ and platform/ changes please. ...
6 years, 7 months ago (2014-05-26 13:21:04 UTC) #12
Srirama
abarth@: Owners review for web/ and platform/ changes please.
6 years, 7 months ago (2014-05-27 14:15:22 UTC) #13
adamk
lgtm for Source/{web,platform}
6 years, 7 months ago (2014-05-27 19:13:28 UTC) #14
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 7 months ago (2014-05-27 19:13:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srirama.m@samsung.com/291303003/1
6 years, 7 months ago (2014-05-27 19:14:45 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 19:14:53 UTC) #17
commit-bot: I haz the power
Failed to apply patch for Source/web/WebMediaPlayerClientImpl.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-27 19:14:54 UTC) #18
Srirama
Rebase with latest code
6 years, 7 months ago (2014-05-28 05:34:31 UTC) #19
Srirama
The CQ bit was checked by srirama.m@samsung.com
6 years, 7 months ago (2014-05-28 05:34:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srirama.m@samsung.com/291303003/20001
6 years, 7 months ago (2014-05-28 05:35:19 UTC) #21
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 06:53:16 UTC) #22
Message was sent while issue was closed.
Change committed as 174940

Powered by Google App Engine
This is Rietveld 408576698