Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2767)

Unified Diff: Source/web/FullscreenController.cpp

Issue 291303003: Eliminate MediaPlayer & MediaPlayerClient abstractions (fullscreen apis) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/media/MediaPlayer.h ('k') | Source/web/WebMediaPlayerClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/FullscreenController.cpp
diff --git a/Source/web/FullscreenController.cpp b/Source/web/FullscreenController.cpp
index 44a6b33be6f5178601947040ac3f79372139e78b..fdb4262617b76ec5417dfcc128468bbdc8949ec7 100644
--- a/Source/web/FullscreenController.cpp
+++ b/Source/web/FullscreenController.cpp
@@ -163,8 +163,8 @@ void FullscreenController::enterFullScreenForElement(WebCore::Element* element)
// FIXME: There is no embedder-side handling in layout test mode.
&& !isRunningLayoutTest()) {
HTMLMediaElement* mediaElement = toHTMLMediaElement(element);
- if (mediaElement->player() && mediaElement->player()->canShowFullscreenOverlay()) {
- mediaElement->player()->showFullscreenOverlay();
+ if (mediaElement->webMediaPlayer() && mediaElement->webMediaPlayer()->canEnterFullscreen()) {
+ mediaElement->webMediaPlayer()->enterFullscreen();
m_provisionalFullScreenElement = element;
return;
}
@@ -187,8 +187,8 @@ void FullscreenController::exitFullScreenForElement(WebCore::Element* element)
// FIXME: There is no embedder-side handling in layout test mode.
&& !isRunningLayoutTest()) {
HTMLMediaElement* mediaElement = toHTMLMediaElement(element);
- if (mediaElement->player())
- mediaElement->player()->hideFullscreenOverlay();
+ if (mediaElement->webMediaPlayer())
+ mediaElement->webMediaPlayer()->exitFullscreen();
return;
}
if (WebViewClient* client = m_webViewImpl->client())
« no previous file with comments | « Source/platform/graphics/media/MediaPlayer.h ('k') | Source/web/WebMediaPlayerClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698