Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2912953002: Disable back button when stack is empty (Closed)

Created:
3 years, 6 months ago by Ian Vollick
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Disable back button when stack is empty If the back stack is empty - The back button icon's color is that of the foreground with an alpha of 0x33 - Hovering over the back button doesn't change its color Note: - tested manually due to time constraints, but we should add a tests BUG=726889 Review-Url: https://codereview.chromium.org/2906403002 Cr-Original-Commit-Position: refs/heads/master@{#475375} Review-Url: https://codereview.chromium.org/2912953002 . Cr-Commit-Position: refs/branch-heads/3112@{#26} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/e8cc130f7fa4718d1656d00276f3303ce48e9393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M chrome/browser/android/vr_shell/color_scheme.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/color_scheme.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 3 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Ian Vollick
3 years, 6 months ago (2017-05-30 12:53:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e8cc130f7fa4718d1656d00276f3303ce48e9393.

Powered by Google App Engine
This is Rietveld 408576698