Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2912923002: Make SelectionController to call TextDistance() with proper range (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, hiroshige+script_chromium.org, kochi+script_chromium.org, kouhei+script_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SelectionController to call TextDistance() with proper range This patch changes |SelectionController::HandleSingleClick()| to call |TextDistance()|, which constructs |TextIterator| via |RangeLength()| with proper range, start <= end, as preparation of making |TextIterator| constructor to take only proper range[1]. [1] http://crrev.com/2912053002: Call TextIterator constructor with proper range BUG=727537 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2912923002 Cr-Commit-Position: refs/heads/master@{#475717} Committed: https://chromium.googlesource.com/chromium/src/+/0711a0a702c23b484eadb514070f20f58b97bb35

Patch Set 1 : 2017-05-30T18:30:35 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
yosin_UTC9
PTAL Note: patch[1] is succeeded.
3 years, 6 months ago (2017-05-30 10:05:06 UTC) #7
Xiaocheng
lgtm
3 years, 6 months ago (2017-05-30 21:03:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912923002/1
3 years, 6 months ago (2017-05-31 01:06:04 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 01:11:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0711a0a702c23b484eadb514070f...

Powered by Google App Engine
This is Rietveld 408576698