Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2912903003: color: Add color spin primaries for layout tests (Closed)

Created:
3 years, 6 months ago by ccameron
Modified:
3 years, 6 months ago
Reviewers:
hubbe
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Add color spin primaries for layout tests Add a "color spin" set of primaries to be used by layout tests. These primaries are rotated RGB->GBR and have a ginormous gamut, so any places where we fail to do color conversion should be very noticeable. BUG=713891 Review-Url: https://codereview.chromium.org/2912903003 Cr-Commit-Position: refs/heads/master@{#475785} Committed: https://chromium.googlesource.com/chromium/src/+/b975a753fe2dae26ef8e6abc0ddc948276e58560

Patch Set 1 #

Patch Set 2 : Rename #

Patch Set 3 : Fix windows build #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M ui/gfx/color_space.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/color_space.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M ui/gfx/color_space_win.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/icc_profile.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M ui/gfx/switches.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
ccameron
ptal -- small change
3 years, 6 months ago (2017-05-30 21:18:44 UTC) #2
hubbe
lgtm
3 years, 6 months ago (2017-05-30 21:55:32 UTC) #3
ccameron
Thanks!
3 years, 6 months ago (2017-05-30 22:04:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912903003/20001
3 years, 6 months ago (2017-05-30 22:05:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/306426)
3 years, 6 months ago (2017-05-30 23:27:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912903003/40001
3 years, 6 months ago (2017-05-31 01:36:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/438029)
3 years, 6 months ago (2017-05-31 01:54:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912903003/60001
3 years, 6 months ago (2017-05-31 02:18:56 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 03:52:59 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b975a753fe2dae26ef8e6abc0ddc...

Powered by Google App Engine
This is Rietveld 408576698