Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2828)

Unified Diff: chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Issue 2912893002: MD Bookmarks: Support policies for disabling bookmark editing (Closed)
Patch Set: canEdit -> globalCanEdit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
diff --git a/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js b/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
index 1cc323b438e4ccd00a65916e81b1ee43b397c674..02cfeacfffc02cefffd7670355b0b0c78cd98e6e 100644
--- a/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
+++ b/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
@@ -91,6 +91,7 @@ suite('drag and drop', function() {
});
store.replaceSingleton();
+ draggedIds = null;
chrome.bookmarkManagerPrivate.startDrag = function(nodes, isTouch) {
draggedIds = nodes;
};
@@ -490,4 +491,40 @@ suite('drag and drop', function() {
assertDeepEquals([], normalizeSet(store.data.selection.items));
dispatchDragEvent('dragend', dragElement);
});
+
+ test('cannot drag items when editing is disabled', function() {
+ store.data.prefs.canEdit = false;
+ store.notifyObservers();
+
+ var dragElement = getFolderNode('11');
+ dispatchDragEvent('dragstart', dragElement);
+ assertEquals(null, draggedIds);
+ });
+
+ test('cannot start dragging unmodifiable items', function() {
+ store.data.nodes['2'].unmodifiable = 'managed';
+ store.notifyObservers();
+
+ var dragElement = getFolderNode('1');
+ dispatchDragEvent('dragstart', dragElement);
+ assertEquals(null, draggedIds);
+
+ dragElement = getFolderNode('2');
+ dispatchDragEvent('dragstart', dragElement);
+ assertEquals(null, draggedIds);
+ });
+
+ test('cannot drag onto folders with unmodifiable children', function() {
+ store.data.nodes['2'].unmodifiable = 'managed';
+ store.notifyObservers();
+
+ var dragElement = getListItem('12');
+ dispatchDragEvent('dragstart', dragElement);
+
+ // Can't drag onto the unmodifiable node.
+ var dragTarget = getFolderNode('2');
+ dispatchDragEvent('dragover', dragTarget);
+ assertEquals(
+ DropPosition.NONE, dndManager.calculateValidDropPositions_(dragTarget));
+ });
});

Powered by Google App Engine
This is Rietveld 408576698