Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5233)

Unified Diff: chrome/test/data/webui/md_bookmarks/command_manager_test.js

Issue 2912893002: MD Bookmarks: Support policies for disabling bookmark editing (Closed)
Patch Set: canEdit -> globalCanEdit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_bookmarks/command_manager_test.js
diff --git a/chrome/test/data/webui/md_bookmarks/command_manager_test.js b/chrome/test/data/webui/md_bookmarks/command_manager_test.js
index a616a69cc81185e39677043b08dc24e87a2c11f5..641c11d45f15d00f473fc61b88e6d13e430299bc 100644
--- a/chrome/test/data/webui/md_bookmarks/command_manager_test.js
+++ b/chrome/test/data/webui/md_bookmarks/command_manager_test.js
@@ -30,6 +30,11 @@ suite('<bookmarks-command-manager>', function() {
'12',
[
createItem('121', {url: 'http://121/'}),
+ createFolder(
+ '122',
+ [
+ createItem('1221'),
+ ]),
]),
createItem('13', {url: 'http://13/'}),
]),
@@ -136,11 +141,11 @@ suite('<bookmarks-command-manager>', function() {
lastDelete = idArray.sort();
};
- var parentAndChildren = new Set(['1', '2', '12', '111']);
+ var parentAndChildren = new Set(['11', '12', '111', '1221']);
assertTrue(commandManager.canExecute(Command.DELETE, parentAndChildren));
commandManager.handle(Command.DELETE, parentAndChildren);
- assertDeepEquals(['1', '2'], lastDelete);
+ assertDeepEquals(['11', '12'], lastDelete);
});
test('expandUrls_ expands one level of URLs', function() {
@@ -187,6 +192,39 @@ suite('<bookmarks-command-manager>', function() {
assertTrue(commandItem[Command.OPEN_INCOGNITO].disabled);
assertFalse(commandItem[Command.OPEN_INCOGNITO].hidden);
});
+
+ test('cannot execute editing commands when editing is disabled', function() {
+ var items = new Set(['12']);
+
+ store.data.prefs.canEdit = false;
+ store.data.selection.items = items;
+ store.notifyObservers();
+
+ assertFalse(commandManager.canExecute(Command.EDIT, items));
+ assertFalse(commandManager.canExecute(Command.DELETE, items));
+ assertFalse(commandManager.canExecute(Command.UNDO, items));
+ assertFalse(commandManager.canExecute(Command.REDO, items));
+
+ // No divider line should be visible when only 'Open' commands are enabled.
+ commandManager.openCommandMenuAtPosition(0, 0);
+ commandManager.root.querySelectorAll('hr').forEach(element => {
+ assertTrue(element.hidden);
+ });
+ });
+
+ test('cannot edit unmodifiable nodes', function() {
+ // Cannot edit root folders.
+ var items = new Set(['1']);
+ assertFalse(commandManager.canExecute(Command.EDIT, items));
+ assertFalse(commandManager.canExecute(Command.DELETE, items));
+
+ store.data.nodes['12'].unmodifiable = 'managed';
+ store.notifyObservers();
+
+ items = new Set(['12']);
+ assertFalse(commandManager.canExecute(Command.EDIT, items));
+ assertFalse(commandManager.canExecute(Command.DELETE, items));
+ });
});
suite('<bookmarks-item> CommandManager integration', function() {

Powered by Google App Engine
This is Rietveld 408576698