extensions/renderer/api_binding.cc - Issue 2912883004: [Extensions Bindings] Don't allow `event` module with native bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_binding.cc

Issue 2912883004: [Extensions Bindings] Don't allow `event` module with native bindings (Closed)

Patch Set: . Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_binding.cc

diff --git a/extensions/renderer/api_binding.cc b/extensions/renderer/api_binding.cc

index 87f8fc27691274ea03aec6109bf9a0336a3fd737..325ee29611f2df755bf9ebcdf2ddff91c439b80c 100644

--- a/extensions/renderer/api_binding.cc

+++ b/extensions/renderer/api_binding.cc

@@ -477,7 +477,7 @@ void APIBinding::GetEventObject(

isolate, new DeclarativeEvent(

event_data->full_name, event_data->binding->type_refs_,

event_data->binding->request_handler_, event_data->actions,

- event_data->conditions));

+ event_data->conditions, 0));

retval = event.ToV8();

} else {

retval = event_data->binding->event_handler_->CreateEventInstance(