Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: extensions/renderer/api_binding.cc

Issue 2912883004: [Extensions Bindings] Don't allow `event` module with native bindings (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/api_binding.h" 5 #include "extensions/renderer/api_binding.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 static_cast<EventData*>(info.Data().As<v8::External>()->Value()); 470 static_cast<EventData*>(info.Data().As<v8::External>()->Value());
471 v8::Local<v8::Value> retval; 471 v8::Local<v8::Value> retval;
472 if (event_data->binding->binding_hooks_->CreateCustomEvent( 472 if (event_data->binding->binding_hooks_->CreateCustomEvent(
473 context, event_data->full_name, &retval)) { 473 context, event_data->full_name, &retval)) {
474 // A custom event was created; our work is done. 474 // A custom event was created; our work is done.
475 } else if (event_data->supports_rules) { 475 } else if (event_data->supports_rules) {
476 gin::Handle<DeclarativeEvent> event = gin::CreateHandle( 476 gin::Handle<DeclarativeEvent> event = gin::CreateHandle(
477 isolate, new DeclarativeEvent( 477 isolate, new DeclarativeEvent(
478 event_data->full_name, event_data->binding->type_refs_, 478 event_data->full_name, event_data->binding->type_refs_,
479 event_data->binding->request_handler_, event_data->actions, 479 event_data->binding->request_handler_, event_data->actions,
480 event_data->conditions)); 480 event_data->conditions, 0));
481 retval = event.ToV8(); 481 retval = event.ToV8();
482 } else { 482 } else {
483 retval = event_data->binding->event_handler_->CreateEventInstance( 483 retval = event_data->binding->event_handler_->CreateEventInstance(
484 event_data->full_name, event_data->supports_filters, 484 event_data->full_name, event_data->supports_filters,
485 event_data->max_listeners, context); 485 event_data->max_listeners, context);
486 } 486 }
487 info.GetReturnValue().Set(retval); 487 info.GetReturnValue().Set(retval);
488 } 488 }
489 489
490 void APIBinding::GetCustomPropertyObject( 490 void APIBinding::GetCustomPropertyObject(
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 name, signature->GetExpectedSignature(), error)); 606 name, signature->GetExpectedSignature(), error));
607 return; 607 return;
608 } 608 }
609 609
610 request_handler_->StartRequest(context, name, std::move(converted_arguments), 610 request_handler_->StartRequest(context, name, std::move(converted_arguments),
611 callback, custom_callback, 611 callback, custom_callback,
612 binding::RequestThread::UI); 612 binding::RequestThread::UI);
613 } 613 }
614 614
615 } // namespace extensions 615 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698