Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2912863004: Move {Left,Right}WordPosition() to static member of SelectionModifier class (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, hiroshige+script_chromium.org, kochi+script_chromium.org, kouhei+script_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move {Left,Right}WordPosition() to static member of SelectionModifier class This patch moves |{Left,Right}WordPosition()| to static member of |SelectionModifier| since they are used only in it to reduce global functions for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2912863004 Cr-Commit-Position: refs/heads/master@{#476148} Committed: https://chromium.googlesource.com/chromium/src/+/8a0412489b22de643aae228c4b33e43f86965e4b

Patch Set 1 : 2017-05-30T17:23:43 #

Patch Set 2 : 2017-05-31T11:26:30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionModifier.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionModifierWord.cpp View 1 4 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-05-31 03:15:43 UTC) #10
yoichio
lgtm
3 years, 6 months ago (2017-05-31 09:35:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912863004/40001
3 years, 6 months ago (2017-05-31 09:37:17 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/468267)
3 years, 6 months ago (2017-05-31 11:37:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912863004/40001
3 years, 6 months ago (2017-06-01 01:03:34 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 02:03:02 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8a0412489b22de643aae228c4b33...

Powered by Google App Engine
This is Rietveld 408576698