Deprecate NonThreadSafe in storage/browser/blob in favor of SequenceChecker.

Deprecate NonThreadSafe in storage/browser/blob in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jianli@chromium.org

Review-Url: https://codereview.chromium.org/2912823002
Cr-Commit-Position: refs/heads/master@{#476415}
Committed: https://chromium.googlesource.com/chromium/src/+/4738228e37a570f880553bad7c77d1d8512fd874

[gab, 2017-05-29 19:19:45]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-29 19:19:48]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-29 19:20:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 20:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 20:19:27]

Dry run: This issue passed the CQ dry run.

[gab, 2017-05-30 01:26:27]

Description was changed from

==========
Deprecate NonThreadSafe in storage/browser/blob in favor of SequenceChecker.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jianli@chromium.org
==========

to

==========
Deprecate NonThreadSafe in storage/browser/blob in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jianli@chromium.org
==========

[gab, 2017-05-31 18:10:15]

friendly ping, please CQ

[jianli, 2017-06-01 18:51:06]

https://codereview.chromium.org/2912823002/diff/1/storage/browser/blob/sharea...
File storage/browser/blob/shareable_file_reference.cc (right):

https://codereview.chromium.org/2912823002/diff/1/storage/browser/blob/sharea...
storage/browser/blob/shareable_file_reference.cc:110:
g_file_map.Get().AssertCalledOnValidSequence();
This will probably add a couple bytes in release code. Is there a way to avoid
it?

[gab, 2017-06-01 19:00:33]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 19:01:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-01 19:02:02]

Done, please CQ

https://codereview.chromium.org/2912823002/diff/1/storage/browser/blob/sharea...
File storage/browser/blob/shareable_file_reference.cc (right):

https://codereview.chromium.org/2912823002/diff/1/storage/browser/blob/sharea...
storage/browser/blob/shareable_file_reference.cc:110:
g_file_map.Get().AssertCalledOnValidSequence();
On 2017/06/01 18:51:05, jianli wrote:
> This will probably add a couple bytes in release code. Is there a way to avoid
> it?

The AssertCalledOnValidSequence() call would be compiled out because the method
will be empty in release builds. But I think you're right that the
g_file_map.Get() call wouldn't be because the compiler can't infer its
side-effects aren't important.

Wrapped everything in #if DCHECK_IS_ON() to be extra safe.

[jianli, 2017-06-01 19:05:12]

lgtm

[gab, 2017-06-01 19:14:08]

The CQ bit was unchecked by gab@chromium.org

[gab, 2017-06-01 19:14:11]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-06-01 19:14:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 20:30:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496344451966340,
"parent_rev": "2d8fb42490681813d05294e44166615c03a6aaff", "commit_rev":
"4738228e37a570f880553bad7c77d1d8512fd874"}

[commit-bot: I haz the power, 2017-06-01 20:30:26]

Description was changed from

==========
Deprecate NonThreadSafe in storage/browser/blob in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jianli@chromium.org
==========

to

==========
Deprecate NonThreadSafe in storage/browser/blob in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jianli@chromium.org

Review-Url: https://codereview.chromium.org/2912823002
Cr-Commit-Position: refs/heads/master@{#476415}
Committed:
https://chromium.googlesource.com/chromium/src/+/4738228e37a570f880553bad7c77...
==========

[commit-bot: I haz the power, 2017-06-01 20:30:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4738228e37a570f880553bad7c77...