Rename "NoBarrier" memory operations to "Relaxed".

Rename "NoBarrier" memory operations to "Relaxed".

This is consistent with C++ memory model and avoids confusion with GC
write barrier.

BUG=

Review-Url: https://codereview.chromium.org/2912773002
Cr-Commit-Position: refs/heads/master@{#45584}
Committed: https://chromium.googlesource.com/v8/v8/+/23cc6be3fcafecf491404e45bad167595b6a2342

[ulan, 2017-05-29 13:07:08]

Description was changed from

==========
Rename "NoBarrier" operations to "Relaxed".

This is consistent with C++ memory model and avoids confusion with GC
write barrier.

BUG=
==========

to

==========
Rename "NoBarrier" load, store operations to "Relaxed".

This is consistent with C++ memory model and avoids confusion with GC
write barrier.

BUG=
==========

[ulan, 2017-05-29 13:07:33]

Description was changed from

==========
Rename "NoBarrier" load, store operations to "Relaxed".

This is consistent with C++ memory model and avoids confusion with GC
write barrier.

BUG=
==========

to

==========
Rename "NoBarrier" memory operations to "Relaxed".

This is consistent with C++ memory model and avoids confusion with GC
write barrier.

BUG=
==========

[ulan, 2017-05-29 13:08:19]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org, mlippautz@chromium.org

[ulan, 2017-05-29 13:08:20]

ptal

https://codereview.chromium.org/2912773002/diff/20001/src/base/atomicops.h
File src/base/atomicops.h (right):

https://codereview.chromium.org/2912773002/diff/20001/src/base/atomicops.h#ne...
src/base/atomicops.h:107: void MemoryBarrier();
I will rename this in another CL.

https://codereview.chromium.org/2912773002/diff/20001/src/base/atomicops.h#ne...
src/base/atomicops.h:122: Atomic64 Barrier_AtomicIncrement(volatile Atomic64*
ptr, Atomic64 increment);
I will rename this in another CL.

[Hannes Payer (out of office), 2017-05-29 13:12:39]

lgtm

https://codereview.chromium.org/2912773002/diff/20001/src/objects/object-macr...
File src/objects/object-macros.h (right):

https://codereview.chromium.org/2912773002/diff/20001/src/objects/object-macr...
src/objects/object-macros.h:83: #define RELAXED_SMI_ACCESSORS(holder, name,
offset)         \
Let's also add a big comment on top of this file explaining their semantics,
what should be the default to use, and what are the dangers.

[Hannes Payer (out of office), 2017-05-29 13:12:39]

lgtm

lgtm

https://codereview.chromium.org/2912773002/diff/20001/src/objects/object-macr...
File src/objects/object-macros.h (right):

https://codereview.chromium.org/2912773002/diff/20001/src/objects/object-macr...
src/objects/object-macros.h:83: #define RELAXED_SMI_ACCESSORS(holder, name,
offset)         \
Let's also add a big comment on top of this file explaining their semantics,
what should be the default to use, and what are the dangers.

[ulan, 2017-05-29 13:18:33]

ulan@chromium.org changed reviewers:
+ jgruber@chromium.org, kozyatinskiy@chromium.org

[ulan, 2017-05-29 13:18:34]

+jgruber for src/debug/*
+kozyatinskiy@ for src/inspector/*

[kozy, 2017-05-29 13:24:01]

Inspector lgtm

[jgruber, 2017-05-29 13:33:51]

debug/ lgtm

[ulan, 2017-05-29 13:41:06]

https://codereview.chromium.org/2912773002/diff/20001/src/objects/object-macr...
File src/objects/object-macros.h (right):

https://codereview.chromium.org/2912773002/diff/20001/src/objects/object-macr...
src/objects/object-macros.h:83: #define RELAXED_SMI_ACCESSORS(holder, name,
offset)         \
On 2017/05/29 13:12:39, Hannes Payer wrote:
> Let's also add a big comment on top of this file explaining their semantics,
> what should be the default to use, and what are the dangers.

atomicops.h has a comment explaining relaxed, acquire, and release on the
high-level.
I added a comment that refers to that.

[ulan, 2017-05-29 13:41:29]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 13:41:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 14:22:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 14:23:00]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2017-05-29 15:47:06]

On 2017/05/29 13:41:06, ulan wrote:
>
https://codereview.chromium.org/2912773002/diff/20001/src/objects/object-macr...
> File src/objects/object-macros.h (right):
> 
>
https://codereview.chromium.org/2912773002/diff/20001/src/objects/object-macr...
> src/objects/object-macros.h:83: #define RELAXED_SMI_ACCESSORS(holder, name,
> offset)         \
> On 2017/05/29 13:12:39, Hannes Payer wrote:
> > Let's also add a big comment on top of this file explaining their semantics,
> > what should be the default to use, and what are the dangers.
> 
> atomicops.h has a comment explaining relaxed, acquire, and release on the
> high-level.
> I added a comment that refers to that.

LGTM

[ulan, 2017-05-29 16:34:37]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-05-29 16:34:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, hpayer@chromium.org, jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2912773002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2017-05-29 16:34:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 16:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 16:37:33]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/41992)

[ulan, 2017-05-30 06:07:11]

ulan@chromium.org changed reviewers:
+ mvstanton@chromium.org

[ulan, 2017-05-30 06:07:12]

+mvstanton@ for ic/*

[mvstanton, 2017-05-30 07:42:07]

lgtm

[ulan, 2017-05-30 07:42:45]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2017-05-30 07:42:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 07:44:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496130165232230,
"parent_rev": "cc2fb993a168f53fd2c84a19c782604ef963305a", "commit_rev":
"23cc6be3fcafecf491404e45bad167595b6a2342"}

[commit-bot: I haz the power, 2017-05-30 07:44:44]

Description was changed from

==========
Rename "NoBarrier" memory operations to "Relaxed".

This is consistent with C++ memory model and avoids confusion with GC
write barrier.

BUG=
==========

to

==========
Rename "NoBarrier" memory operations to "Relaxed".

This is consistent with C++ memory model and avoids confusion with GC
write barrier.

BUG=

Review-Url: https://codereview.chromium.org/2912773002
Cr-Commit-Position: refs/heads/master@{#45584}
Committed:
https://chromium.googlesource.com/v8/v8/+/23cc6be3fcafecf491404e45bad167595b6...
==========

[commit-bot: I haz the power, 2017-05-30 07:44:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/23cc6be3fcafecf491404e45bad167595b6...