Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2912753004: [css-typed-om] use USVString for URLs at CSSURLImageValue. (Closed)

Created:
3 years, 6 months ago by Hwanseung Lee
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-typed-om] use USVString for URLs at CSSURLImageValue. use USVString for URLs instead of DOMString at CSSURLImageValue.idl https://drafts.css-houdini.org/css-typed-om-1/#cssurlimagevalue BUG=545318 Review-Url: https://codereview.chromium.org/2912753004 Cr-Commit-Position: refs/heads/master@{#475425} Committed: https://chromium.googlesource.com/chromium/src/+/51f2415dd7e2008cb232c11ccc1bc5cdb79334c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/cssom/CSSURLImageValue.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Hwanseung Lee
PTAL. thank you.
3 years, 6 months ago (2017-05-29 23:21:27 UTC) #6
meade_UTC10
lgtm Hey I was wondering, we have a bunch of work remaining on CSS Properties ...
3 years, 6 months ago (2017-05-30 03:59:34 UTC) #7
Hwanseung Lee
On 2017/05/30 03:59:34, meade_UTC10 wrote: > lgtm > > Hey I was wondering, we have ...
3 years, 6 months ago (2017-05-30 04:32:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912753004/1
3 years, 6 months ago (2017-05-30 04:32:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/51f2415dd7e2008cb232c11ccc1bc5cdb79334c0
3 years, 6 months ago (2017-05-30 04:36:02 UTC) #13
meade_UTC10
3 years, 6 months ago (2017-06-02 04:03:22 UTC) #14
Message was sent while issue was closed.
On 2017/05/30 04:32:08, Hwanseung Lee wrote:
> On 2017/05/30 03:59:34, meade_UTC10 wrote:
> > lgtm
> > 
> > Hey I was wondering, we have a bunch of work remaining on CSS Properties and
> > Values that it'd be great to have someone work on. Would you like to have a
> > crack at that next? (spec:
> > https://drafts.css-houdini.org/css-properties-values-api)
> 
> thanks, i had been finding the somthings in order to contribute code.
> and than, i found the css-typed-om.
> i appreciate your suggestion. 
> i had used CSS to make website, 
> but i don't know well how to work CSS in browser side.
> so i think i need a some time in order to upload patch.
> anyway, i will study about it, and i upload patch as soon as possible.

Great, thank you! I sent you an email with some pointers.

Powered by Google App Engine
This is Rietveld 408576698