Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2912683002: Generate methods for Hyphens and HyphenationString in ComputedStyleBase. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate methods for Hyphens and HyphenationString in ComputedStyleBase. This patch generates getters/setters/mapping for Hyphens and HyphenationString. Diff of generated files: https://gist.github.com/darrnshn/7e96b6fcf479bc4828bcd64200ddabde/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2912683002 Cr-Commit-Position: refs/heads/master@{#475333} Committed: https://chromium.googlesource.com/chromium/src/+/a848cb705b2c3764f9ec2099ba3b2525e450f746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -57 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-29 01:48:22 UTC) #5
rune
lgtm
3 years, 6 months ago (2017-05-29 09:35:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912683002/1
3 years, 6 months ago (2017-05-29 10:48:26 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 10:52:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a848cb705b2c3764f9ec2099ba3b...

Powered by Google App Engine
This is Rietveld 408576698