Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Issue 2912673002: Make StyleRareNonInheritedData::draggable_regions a bit field. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10, Bugs Nash
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make StyleRareNonInheritedData::draggable_regions a bit field. This patch changes the enum field draggable_regions in StyleRareNonInheritedData a bit field so that it can be generated as a keyword field. The field is stored as an unsigned so that it can pack efficiently on Windows. BUG=628043 Review-Url: https://codereview.chromium.org/2912673002 Cr-Commit-Position: refs/heads/master@{#475448} Committed: https://chromium.googlesource.com/chromium/src/+/e6fa9ad53a68ce6204ade3cb16b0d8cf7090858a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
shend
Hi Bugs, PTAL
3 years, 6 months ago (2017-05-28 22:55:56 UTC) #4
Bugs Nash
lgtm
3 years, 6 months ago (2017-05-29 01:35:16 UTC) #7
Bugs Nash
On 2017/05/29 at 01:35:16, Bugs Nash wrote: > lgtm perhaps add comment as to why ...
3 years, 6 months ago (2017-05-29 01:36:00 UTC) #8
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-29 01:42:45 UTC) #11
meade_UTC10
lgtm
3 years, 6 months ago (2017-05-30 03:48:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912673002/1
3 years, 6 months ago (2017-05-30 07:01:32 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 07:05:47 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6fa9ad53a68ce6204ade3cb16b0...

Powered by Google App Engine
This is Rietveld 408576698