Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2912573002: Log the analysis options path. (Closed)

Created:
3 years, 7 months ago by devoncarew
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Log the analysis options path. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
devoncarew
This CL writes the analysis options location to the analysis server's print() output. With regular ...
3 years, 7 months ago (2017-05-26 22:18:49 UTC) #2
devoncarew
This CL writes the analysis options location to the analysis server's print() output. With regular ...
3 years, 7 months ago (2017-05-26 22:18:50 UTC) #3
Paul Berry
lgtm
3 years, 7 months ago (2017-05-26 22:27:52 UTC) #4
Brian Wilkerson
I suppose what you have is fine, but it seems like if you want it ...
3 years, 6 months ago (2017-05-27 04:20:26 UTC) #5
devoncarew
3 years, 6 months ago (2017-05-27 18:01:02 UTC) #6
On 2017/05/27 04:20:26, Brian Wilkerson wrote:
> I suppose what you have is fine, but it seems like if you want it on the
status
> pages it would be better to just display it on the "Context" page under
> "Configuration" (without having to search through the print output).

I wasn't entirely sure how to plumb the information through, and this seemed to
parallel what we're doing on the cli. I have some work now to add the options
path to the diagnostics page - I'll put that up for review.

Powered by Google App Engine
This is Rietveld 408576698