Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2912533002:
Add jessie-security repo to sysroot scripts (Closed)
|
Created:
3 years, 7 months ago by Tom Anderson Modified:
3 years, 7 months ago Reviewers:
Lei Zhang CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd jessie-security repo to sysroot scripts
This CL adds a more general syntax for specify apt sources for
sysroot-creator.sh, similar to /etc/apt/sources.list. Whereas
previously there was only APT_REPO, this CL allows specifying multiple
repos so that we can get "security.debian.org" in addition to
"ftp.us.debian.org".
BUG=691261
R=thestig@chromium.org
Review-Url: https://codereview.chromium.org/2912533002
Cr-Commit-Position: refs/heads/master@{#475209}
Committed: https://chromium.googlesource.com/chromium/src/+/c61e0b14d96fcb5c4592d2c12551994f879e5490
Patch Set 1 #
Total comments: 4
Patch Set 2 : Address thestig@'s comments #
Messages
Total messages: 24 (13 generated)
Patchset #4 (id:60001) has been deleted
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== Add jessie-security repo to sysroot scripts BUG=691261 R=thestig@chromium.org ========== to ========== Add jessie-security repo to sysroot scripts This CL adds a more general syntax for specify apt sources for sysroot-creator.sh, similar to /etc/apt/sources.list. Whereas previously there was only APT_REPO, this CL allows specifying multiple repos so that we can get "security.debian.org" in addition to "ftp.us.debian.org". BUG=691261 R=thestig@chromium.org ==========
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
How do I verify the .gpg change?
On 2017/05/27 00:26:06, Lei Zhang wrote: > How do I verify the .gpg change? export KEYS="518E17E1 46925553 2B90D010 C857C906" gpg --recv-keys $KEYS gpg --output ./test-debian-archive-jessie-stable.gpg --export $KEYS cmp ./test-debian-archive-jessie-stable.gpg ./debian-archive-jessie-stable.gpg
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2912533002/diff/50004/build/linux/sysroot_scr... File build/linux/sysroot_scripts/sysroot-creator.sh (right): https://codereview.chromium.org/2912533002/diff/50004/build/linux/sysroot_scr... build/linux/sysroot_scripts/sysroot-creator.sh:184: ExtractPackageGz() { Add some locals so we know what the arguments are? Previously it was more obvious what $1 and $2 is, but now $3 is not as obvious.
https://codereview.chromium.org/2912533002/diff/50004/build/linux/sysroot_scr... File build/linux/sysroot_scripts/sysroot-creator.sh (right): https://codereview.chromium.org/2912533002/diff/50004/build/linux/sysroot_scr... build/linux/sysroot_scripts/sysroot-creator.sh:106: curl "$1" --create-dirs -o "${2}.partial.$$" Oh, REQUIRED_TOOLS needs updating.
On 2017/05/27 00:28:58, Tom Anderson wrote: > On 2017/05/27 00:26:06, Lei Zhang wrote: > > How do I verify the .gpg change? > > export KEYS="518E17E1 46925553 2B90D010 C857C906" > gpg --recv-keys $KEYS > gpg --output ./test-debian-archive-jessie-stable.gpg --export $KEYS > cmp ./test-debian-archive-jessie-stable.gpg ./debian-archive-jessie-stable.gpg Well, I can't actually download it via the web interface, so I'm going to assume it's ok.
On 2017/05/27 00:40:10, Lei Zhang wrote: > On 2017/05/27 00:28:58, Tom Anderson wrote: > > On 2017/05/27 00:26:06, Lei Zhang wrote: > > > How do I verify the .gpg change? > > > > export KEYS="518E17E1 46925553 2B90D010 C857C906" > > gpg --recv-keys $KEYS > > gpg --output ./test-debian-archive-jessie-stable.gpg --export $KEYS > > cmp ./test-debian-archive-jessie-stable.gpg ./debian-archive-jessie-stable.gpg > > Well, I can't actually download it via the web interface, so I'm going to assume > it's ok. https://codereview.chromium.org/download/issue2912533002_50004_80001.diff
On 2017/05/27 00:41:57, Tom Anderson wrote: > On 2017/05/27 00:40:10, Lei Zhang wrote: > > On 2017/05/27 00:28:58, Tom Anderson wrote: > > > On 2017/05/27 00:26:06, Lei Zhang wrote: > > > > How do I verify the .gpg change? > > > > > > export KEYS="518E17E1 46925553 2B90D010 C857C906" > > > gpg --recv-keys $KEYS > > > gpg --output ./test-debian-archive-jessie-stable.gpg --export $KEYS > > > cmp ./test-debian-archive-jessie-stable.gpg > ./debian-archive-jessie-stable.gpg > > > > Well, I can't actually download it via the web interface, so I'm going to > assume > > it's ok. > > https://codereview.chromium.org/download/issue2912533002_50004_80001.diff nvm
https://codereview.chromium.org/2912533002/diff/50004/build/linux/sysroot_scr... File build/linux/sysroot_scripts/sysroot-creator.sh (right): https://codereview.chromium.org/2912533002/diff/50004/build/linux/sysroot_scr... build/linux/sysroot_scripts/sysroot-creator.sh:106: curl "$1" --create-dirs -o "${2}.partial.$$" On 2017/05/27 00:38:45, Lei Zhang wrote: > Oh, REQUIRED_TOOLS needs updating. Done. https://codereview.chromium.org/2912533002/diff/50004/build/linux/sysroot_scr... build/linux/sysroot_scripts/sysroot-creator.sh:184: ExtractPackageGz() { On 2017/05/27 00:37:42, Lei Zhang wrote: > Add some locals so we know what the arguments are? Previously it was more > obvious what $1 and $2 is, but now $3 is not as obvious. Done.
The CQ bit was checked by thomasanderson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org Link to the patchset: https://codereview.chromium.org/2912533002/#ps90001 (title: "Address thestig@'s comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 90001, "attempt_start_ts": 1495846369045570,
"parent_rev": "a48fb23b269530993d83bb21d99dd5833372022e", "commit_rev":
"c61e0b14d96fcb5c4592d2c12551994f879e5490"}
Message was sent while issue was closed.
Description was changed from ========== Add jessie-security repo to sysroot scripts This CL adds a more general syntax for specify apt sources for sysroot-creator.sh, similar to /etc/apt/sources.list. Whereas previously there was only APT_REPO, this CL allows specifying multiple repos so that we can get "security.debian.org" in addition to "ftp.us.debian.org". BUG=691261 R=thestig@chromium.org ========== to ========== Add jessie-security repo to sysroot scripts This CL adds a more general syntax for specify apt sources for sysroot-creator.sh, similar to /etc/apt/sources.list. Whereas previously there was only APT_REPO, this CL allows specifying multiple repos so that we can get "security.debian.org" in addition to "ftp.us.debian.org". BUG=691261 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2912533002 Cr-Commit-Position: refs/heads/master@{#475209} Committed: https://chromium.googlesource.com/chromium/src/+/c61e0b14d96fcb5c4592d2c12551... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:90001) as https://chromium.googlesource.com/chromium/src/+/c61e0b14d96fcb5c4592d2c12551... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
