Test util to allow MultiThreaded tests on TSan

Test util to allow MultiThreaded tests on TSan

BUG=724565
Review-Url: https://codereview.chromium.org/2912523002
Cr-Commit-Position: refs/heads/master@{#475227}
Committed: https://chromium.googlesource.com/chromium/src/+/060a08af91bdc5a090a78e852d4470c52458c004

[fserb, 2017-05-26 19:04:27]

fserb@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-05-26 19:13:13]

Directory name "off" is a bit vague.  Perhaps "threaded"?

https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h (right):

https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h:29:
threads.push_back(Platform::Current()->CreateThread("one"));
thread name...

https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h:40: FROM_HERE,
CrossThreadBind(
See if you can eliminate nested CrossThreadBinds

[fserb, 2017-05-26 20:49:48]

Done.

https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h (right):

https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h:29:
threads.push_back(Platform::Current()->CreateThread("one"));
On 2017/05/26 at 19:13:13, Justin Novosad wrote:
> thread name...

done.

https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h:40: FROM_HERE,
CrossThreadBind(
On 2017/05/26 at 19:13:13, Justin Novosad wrote:
> See if you can eliminate nested CrossThreadBinds

done.

[Justin Novosad, 2017-05-26 21:09:57]

On 2017/05/26 20:49:48, fserb wrote:
> Done.
> 
>
https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h (right):
> 
>
https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h:29:
> threads.push_back(Platform::Current()->CreateThread("one"));
> On 2017/05/26 at 19:13:13, Justin Novosad wrote:
> > thread name...
> 
> done.
> 
>
https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h:40: FROM_HERE,
> CrossThreadBind(
> On 2017/05/26 at 19:13:13, Justin Novosad wrote:
> > See if you can eliminate nested CrossThreadBinds
> 
> done.

lgtm

[fserb, 2017-05-27 00:22:57]

The CQ bit was checked by fserb@chromium.org

[commit-bot: I haz the power, 2017-05-27 00:23:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 03:03:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495844577420300,
"parent_rev": "0b1506a3f67ecc784f791bc6dd60d0071f57f6ee", "commit_rev":
"060a08af91bdc5a090a78e852d4470c52458c004"}

[commit-bot: I haz the power, 2017-05-27 03:04:08]

Description was changed from

==========
Test util to allow MultiThreaded tests on TSan

BUG=724565
==========

to

==========
Test util to allow MultiThreaded tests on TSan

BUG=724565

Review-Url: https://codereview.chromium.org/2912523002
Cr-Commit-Position: refs/heads/master@{#475227}
Committed:
https://chromium.googlesource.com/chromium/src/+/060a08af91bdc5a090a78e852d44...
==========

[commit-bot: I haz the power, 2017-05-27 03:04:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/060a08af91bdc5a090a78e852d44...