Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2912523002: Test util to allow MultiThreaded tests on TSan (Closed)

Created:
3 years, 7 months ago by fserb
Modified:
3 years, 7 months ago
Reviewers:
Justin Novosad
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Test util to allow MultiThreaded tests on TSan BUG=724565 Review-Url: https://codereview.chromium.org/2912523002 Cr-Commit-Position: refs/heads/master@{#475227} Committed: https://chromium.googlesource.com/chromium/src/+/060a08af91bdc5a090a78e852d4470c52458c004

Patch Set 1 #

Total comments: 4

Patch Set 2 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
A third_party/WebKit/Source/core/css/threaded/MultiThreadedTestUtil.h View 1 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fserb
3 years, 7 months ago (2017-05-26 19:04:28 UTC) #2
Justin Novosad
Directory name "off" is a bit vague. Perhaps "threaded"? https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h File third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h (right): https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h#newcode29 third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h:29: ...
3 years, 7 months ago (2017-05-26 19:13:13 UTC) #3
fserb
Done. https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h File third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h (right): https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h#newcode29 third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h:29: threads.push_back(Platform::Current()->CreateThread("one")); On 2017/05/26 at 19:13:13, Justin Novosad wrote: ...
3 years, 7 months ago (2017-05-26 20:49:48 UTC) #4
Justin Novosad
On 2017/05/26 20:49:48, fserb wrote: > Done. > > https://codereview.chromium.org/2912523002/diff/1/third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h > File third_party/WebKit/Source/core/css/off/MultiThreadedTestUtil.h (right): > ...
3 years, 7 months ago (2017-05-26 21:09:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912523002/20001
3 years, 7 months ago (2017-05-27 00:23:17 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-27 03:04:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/060a08af91bdc5a090a78e852d44...

Powered by Google App Engine
This is Rietveld 408576698