Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2912473002: Fix an IME bug where RWHImpl::ImeFinishCompositingText is called twice in a row (Closed)
Patch Set: Modified the Test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_event_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 6800c342bfa7cfdc26a132af41f112589f57b771..97ff6d25e07dff664c9c988cea17f869f8979707 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -1580,13 +1580,10 @@ TEST_F(RenderWidgetHostViewAuraTest, FinishCompositionByMouse) {
EXPECT_EQ(2U, sink_->message_count());
- if (sink_->message_count() == 2) {
- // Verify mouse event happens after the finish composing text event.
- EXPECT_EQ(InputMsg_ImeFinishComposingText::ID,
- sink_->GetMessageAt(0)->type());
- EXPECT_EQ(InputMsg_HandleInputEvent::ID,
- sink_->GetMessageAt(1)->type());
- }
+ // Verify mouse event happens after the finish composing text event.
+ EXPECT_EQ(InputMsg_ImeFinishComposingText::ID,
sadrul 2017/05/30 21:03:03 ASSERT that sink_->message_count() >= 2 before acc
Shu Chen 2017/05/31 01:16:36 +1. Can we assert message_count == 2? Or can we ch
EhsanK 2017/05/31 13:48:24 Thanks! Changed the EXPECT on line 1581 into ASSER
+ sink_->GetMessageAt(0)->type());
+ EXPECT_EQ(InputMsg_HandleInputEvent::ID, sink_->GetMessageAt(1)->type());
}
// Checks that touch-event state is maintained correctly.
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_event_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698