Fix an IME bug where RWHImpl::ImeFinishCompositingText is called twice in a row

content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <tuple>
@@ skipping 1562 matching lines @@
   // Simulates the mouse press.
   ui::MouseEvent mouse_event(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
                              ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON,
                              0);
   view_->OnMouseEvent(&mouse_event);
 
   EXPECT_FALSE(view_->has_composition_text_);
 
   EXPECT_EQ(2U, sink_->message_count());
 
-  if (sink_->message_count() == 2) {
-    // Verify mouse event happens after the finish composing text event.
-    EXPECT_EQ(InputMsg_ImeFinishComposingText::ID,
-              sink_->GetMessageAt(0)->type());
-    EXPECT_EQ(InputMsg_HandleInputEvent::ID,
-              sink_->GetMessageAt(1)->type());
-  }
+  // Verify mouse event happens after the finish composing text event.
+  EXPECT_EQ(InputMsg_ImeFinishComposingText::ID,

[sadrul, 2017/05/30 21:03:03]

ASSERT that sink_->message_count() >= 2 before accessing GetMessageAt(0)/1 to
avoid crashes on failure.

[Shu Chen, 2017/05/31 01:16:36]

+1. Can we assert message_count == 2? Or can we check no dup
ImeFinishComposingText?

[EhsanK, 2017/05/31 13:48:24]

Thanks! Changed the EXPECT on line 1581 into ASSERT.

+            sink_->GetMessageAt(0)->type());
+  EXPECT_EQ(InputMsg_HandleInputEvent::ID, sink_->GetMessageAt(1)->type());
 }
 
 // Checks that touch-event state is maintained correctly.
 TEST_F(RenderWidgetHostViewAuraRafAlignedTouchDisabledTest, TouchEventState) {
   view_->InitAsChild(nullptr);
   view_->Show();
   GetSentMessageCountAndResetSink();
 
   // Start with no touch-event handler in the renderer.
   widget_host_->OnMessageReceived(ViewHostMsg_HasTouchEventHandlers(0, false));
@@ skipping 4292 matching lines @@
     // There is no composition in the beginning.
     EXPECT_FALSE(has_composition_text());
     SetHasCompositionTextToTrue();
     view->ImeCancelComposition();
     // The composition must have been canceled.
     EXPECT_FALSE(has_composition_text());
   }
 }
 
 }  // namespace content