Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2912453002: [Payments] Make payment instrument labels dynamic (Closed)

Created:
3 years, 6 months ago by MAD
Modified:
3 years, 6 months ago
Reviewers:
Mathieu, macourteau
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, tfarina, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make payment instrument labels dynamic BUG=715075 Review-Url: https://codereview.chromium.org/2912453002 Cr-Commit-Position: refs/heads/master@{#475063} Committed: https://chromium.googlesource.com/chromium/src/+/d84e0a6943fb2d5081ff2519a862395b9b26e107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -27 lines) Patch
M chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_method_view_controller.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M components/payments/core/autofill_payment_instrument.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/payments/core/autofill_payment_instrument.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M components/payments/core/payment_instrument.h View 1 chunk +3 lines, -6 lines 0 comments Download
M components/payments/core/payment_instrument.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
MAD
Fixed as discussed...
3 years, 6 months ago (2017-05-26 14:57:55 UTC) #2
Mathieu
This is great! lgtm
3 years, 6 months ago (2017-05-26 16:33:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912453002/1
3 years, 6 months ago (2017-05-26 16:43:53 UTC) #10
MAD
Thanks, but I might not be able to commit this because of the failure in ...
3 years, 6 months ago (2017-05-26 16:45:13 UTC) #12
macourteau
On 2017/05/26 16:45:13, MAD wrote: > Thanks, but I might not be able to commit ...
3 years, 6 months ago (2017-05-26 17:18:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/224581)
3 years, 6 months ago (2017-05-26 17:21:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912453002/1
3 years, 6 months ago (2017-05-26 18:10:31 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 18:24:46 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d84e0a6943fb2d5081ff2519a862...

Powered by Google App Engine
This is Rietveld 408576698