Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2912413002:
Use PreferenceCategory instead of manual preference ordering (Closed)
|
Created:
3 years, 6 months ago by bsazonov Modified:
3 years, 6 months ago Reviewers:
David Trainor- moved to gerrit CC:
chromium-reviews, agrieve+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse PreferenceCategory instead of manual preference ordering
This CL removes manual Preference ordering in AccountManagementFragment.
Instead it puts all account-related preference rows in a PreferenceCategory
and cleans this category whenever needed.
BUG=722910
Review-Url: https://codereview.chromium.org/2912413002
Cr-Commit-Position: refs/heads/master@{#476649}
Committed: https://chromium.googlesource.com/chromium/src/+/b08320999af0d7e05789d81e4d8ded9c506aab3f
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix condition #Patch Set 3 : Rebase #
Messages
Total messages: 28 (18 generated)
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bsazonov@chromium.org changed reviewers: + dtrainor@chromium.org
David, please take a look. This CL is a preparation for the account row changes requested by the UX team.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2912413002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java (right): https://codereview.chromium.org/2912413002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java:393: if (isChildAccount) { Should this be !isChildAccount? I'm assuming we want non-children to be able to add accounts? Or am I misunderstanding this? :)
https://codereview.chromium.org/2912413002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java (right): https://codereview.chromium.org/2912413002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java:393: if (isChildAccount) { On 2017/05/31 15:57:14, David Trainor-ping if over 24h wrote: > Should this be !isChildAccount? I'm assuming we want non-children to be able to > add accounts? Or am I misunderstanding this? :) Oops! Sorry for that. Thanks a lot for catching this! Fixed.
lgtm
The CQ bit was checked by bsazonov@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by bsazonov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dtrainor@chromium.org Link to the patchset: https://codereview.chromium.org/2912413002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bsazonov@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496415307957570,
"parent_rev": "a19c77077f663f771e822ffb025d9cc607e9cf8e", "commit_rev":
"34caa5031fa1dd3c7e2b46b063e0368cc86cbb68"}
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496415307957570,
"parent_rev": "04b4c66b52e636caee92c6e0788dbb17a639f96f", "commit_rev":
"b08320999af0d7e05789d81e4d8ded9c506aab3f"}
Message was sent while issue was closed.
Description was changed from ========== Use PreferenceCategory instead of manual preference ordering This CL removes manual Preference ordering in AccountManagementFragment. Instead it puts all account-related preference rows in a PreferenceCategory and cleans this category whenever needed. BUG=722910 ========== to ========== Use PreferenceCategory instead of manual preference ordering This CL removes manual Preference ordering in AccountManagementFragment. Instead it puts all account-related preference rows in a PreferenceCategory and cleans this category whenever needed. BUG=722910 Review-Url: https://codereview.chromium.org/2912413002 Cr-Commit-Position: refs/heads/master@{#476649} Committed: https://chromium.googlesource.com/chromium/src/+/b08320999af0d7e05789d81e4d8d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/b08320999af0d7e05789d81e4d8d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
