Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

Issue 2912403004: [Mac] Mirror bookmark bubble folder dropdown in RTL (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
index 4375e5b96902fff2e02fc71d55a1082ec20ee2e3..b37dd7d714b67c796920f14e0a35c8020bcba3fd 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
@@ -329,6 +329,11 @@ using bookmarks::BookmarkNode;
cocoa_l10n_util::FlipAllSubviewsIfNecessary([nameTextField_ superview]);
// Relative order of the done and options buttons.
cocoa_l10n_util::FlipAllSubviewsIfNecessary(trailingButtonContainer_);
+ if (cocoa_l10n_util::ShouldDoExperimentalRTLLayout()) {
+ [folderPopUpButton_ setUserInterfaceLayoutDirection:
+ NSUserInterfaceLayoutDirectionRightToLeft];
+ [folderPopUpButton_ setAlignment:NSNaturalTextAlignment];
Sidney San Martín 2017/06/01 18:52:19 nit: It looks like this is only needed because fol
lgrey 2017/06/02 16:10:18 Done.
+ }
}
@end // BookmarkBubbleController
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698