Add a feature for not compositing small scrollers

Add a feature for not compositing small scrollers

We find that more than ~60% scrollers(scrollbars) are smaller than
certain size and only 10% of them gets scrolled by users. As a result,
we are thinking of not compositing the small scrollers to save GPU
memory. The experiment is to investigate how much memory gains we could
get without compositing them. Having a finch experiment in place will
provide us with data for evaluating the GPU memory usage for not
compositing small scrollers.

This patch is to add a relative feature.

BUG=728267
Review-Url: https://codereview.chromium.org/2912403003
Cr-Commit-Position: refs/heads/master@{#477753}
Committed: https://chromium.googlesource.com/chromium/src/+/3abfb995607fad374795c7abd737c4d012e7d7b0

[yigu, 2017-06-01 13:40:00]

Description was changed from

==========
Add a field trial for not compositing small scrollers

Having a finch experiment in place will provide us with data for
evaluating the GPU memory usage for not compositing small scrollers.

BUG=728267
==========

to

==========
Add a field trial for not compositing small scrollers

Having a finch experiment in place will provide us with data for
evaluating the GPU memory usage for not compositing small scrollers.

BUG=728267
==========

[yigu, 2017-06-01 13:40:00]

yigu@chromium.org changed reviewers:
+ jwd@chromium.org

[jwd, 2017-06-02 18:27:35]

Can you update the CL description. You're not adding a field trial, you're
adding a feature.

https://codereview.chromium.org/2912403003/diff/1/content/public/common/conte...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2912403003/diff/1/content/public/common/conte...
content/public/common/content_features.cc:148: "kNotCompositeSmallScroller",
base::FEATURE_DISABLED_BY_DEFAULT};
Nit: Add a newline after this.

https://codereview.chromium.org/2912403003/diff/1/content/public/common/conte...
content/public/common/content_features.cc:148: "kNotCompositeSmallScroller",
base::FEATURE_DISABLED_BY_DEFAULT};
Nit: Don't include the k in the string name of the feature.

[yigu, 2017-06-02 18:34:49]

Description was changed from

==========
Add a field trial for not compositing small scrollers

Having a finch experiment in place will provide us with data for
evaluating the GPU memory usage for not compositing small scrollers.

BUG=728267
==========

to

==========
Add a feature for not compositing small scrollers

Having a finch experiment in place will provide us with data for
evaluating the GPU memory usage for not compositing small scrollers.

BUG=728267
==========

[yigu, 2017-06-02 18:39:02]

Thanks Jesse! Have updated the patch.

https://codereview.chromium.org/2912403003/diff/1/content/public/common/conte...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2912403003/diff/1/content/public/common/conte...
content/public/common/content_features.cc:148: "kNotCompositeSmallScroller",
base::FEATURE_DISABLED_BY_DEFAULT};
On 2017/06/02 18:27:35, jwd wrote:
> Nit: Don't include the k in the string name of the feature.

Done.

[jwd, 2017-06-02 20:57:35]

lgtm

[yigu, 2017-06-05 14:21:25]

Description was changed from

==========
Add a feature for not compositing small scrollers

Having a finch experiment in place will provide us with data for
evaluating the GPU memory usage for not compositing small scrollers.

BUG=728267
==========

to

==========
Add a feature for not compositing small scrollers

We find that more than ~60% scrollers(scrollbars) are smaller than certain size
and only 10% of them gets scrolled by users. As a result, we are thinking of not
compositing the small scrollers to save GPU memory. The experiment is to
investigate how much memory gains we could get without compositing them. Having
a finch experiment in place will provide us with data for evaluating the GPU
memory usage for not compositing small scrollers.

This patch is to add a relative feature.

BUG=728267
==========

[yigu, 2017-06-05 14:21:25]

yigu@chromium.org changed reviewers:
+ flackr@chromium.org, kinuko@chromium.org

[yigu, 2017-06-05 14:22:05]

Description was changed from

==========
Add a feature for not compositing small scrollers

We find that more than ~60% scrollers(scrollbars) are smaller than certain size
and only 10% of them gets scrolled by users. As a result, we are thinking of not
compositing the small scrollers to save GPU memory. The experiment is to
investigate how much memory gains we could get without compositing them. Having
a finch experiment in place will provide us with data for evaluating the GPU
memory usage for not compositing small scrollers.

This patch is to add a relative feature.

BUG=728267
==========

to

==========
Add a feature for not compositing small scrollers

We find that more than ~60% scrollers(scrollbars) are smaller than
certain size and only 10% of them gets scrolled by users. As a result,
we are thinking of not compositing the small scrollers to save GPU
memory. The experiment is to investigate how much memory gains we could
get without compositing them. Having a finch experiment in place will
provide us with data for evaluating the GPU memory usage for not
compositing small scrollers.

This patch is to add a relative feature.

BUG=728267
==========

[yigu, 2017-06-05 14:23:54]

Hello flackr and kinuko! PTAL at the patch that adds feature for not compositing
small scrollers. Thanks!

[flackr, 2017-06-05 17:50:41]

https://codereview.chromium.org/2912403003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2912403003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:695: name:
"NotCompositeSmallScroller",
Suggestion, how about SkipCompositingSmallScrollers or
CompositeOnlyLargeScrollers?

https://codereview.chromium.org/2912403003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:696: status:
"experimental",
I think status experimental means this would be enabled with
--experimental-web-platform-features which I don't think we should do until this
feature is implemented.

[kinuko, 2017-06-06 04:28:33]

lgtm if flackr's comments are addressed.

[yigu, 2017-06-06 20:01:11]

Thanks for the suggestion. PTAL.

https://codereview.chromium.org/2912403003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2912403003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:695: name:
"NotCompositeSmallScroller",
On 2017/06/05 17:50:41, flackr wrote:
> Suggestion, how about SkipCompositingSmallScrollers or
> CompositeOnlyLargeScrollers?

Done.

https://codereview.chromium.org/2912403003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:696: status:
"experimental",
On 2017/06/05 17:50:41, flackr wrote:
> I think status experimental means this would be enabled with
> --experimental-web-platform-features which I don't think we should do until
this
> feature is implemented.

Have updated it to "test".

[flackr, 2017-06-07 17:07:47]

lgtm

[yigu, 2017-06-07 17:08:01]

The CQ bit was checked by yigu@chromium.org

[yigu, 2017-06-07 17:08:01]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2912403003/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-06-07 17:08:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 17:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 17:46:15]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yigu, 2017-06-07 18:08:54]

The CQ bit was checked by yigu@chromium.org

[yigu, 2017-06-07 18:08:55]

The patchset sent to the CQ was uploaded after l-g-t-m from flackr@chromium.org,
kinuko@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2912403003/#ps60001
(title: "Use uppercase-initial format for RuntimeEnabledFeature due to another
patch that was landed earlier…")

[commit-bot: I haz the power, 2017-06-07 18:09:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 20:37:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496858934567370,
"parent_rev": "6c9e916ccc52236c4b4cf176d0bbe1299e9de7e7", "commit_rev":
"3abfb995607fad374795c7abd737c4d012e7d7b0"}

[commit-bot: I haz the power, 2017-06-07 20:37:33]

Description was changed from

==========
Add a feature for not compositing small scrollers

We find that more than ~60% scrollers(scrollbars) are smaller than
certain size and only 10% of them gets scrolled by users. As a result,
we are thinking of not compositing the small scrollers to save GPU
memory. The experiment is to investigate how much memory gains we could
get without compositing them. Having a finch experiment in place will
provide us with data for evaluating the GPU memory usage for not
compositing small scrollers.

This patch is to add a relative feature.

BUG=728267
==========

to

==========
Add a feature for not compositing small scrollers

We find that more than ~60% scrollers(scrollbars) are smaller than
certain size and only 10% of them gets scrolled by users. As a result,
we are thinking of not compositing the small scrollers to save GPU
memory. The experiment is to investigate how much memory gains we could
get without compositing them. Having a finch experiment in place will
provide us with data for evaluating the GPU memory usage for not
compositing small scrollers.

This patch is to add a relative feature.

BUG=728267

Review-Url: https://codereview.chromium.org/2912403003
Cr-Commit-Position: refs/heads/master@{#477753}
Committed:
https://chromium.googlesource.com/chromium/src/+/3abfb995607fad374795c7abd737...
==========

[commit-bot: I haz the power, 2017-06-07 20:37:35]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3abfb995607fad374795c7abd737...